From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrYBA-00012c-DP for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:46:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrYB5-0006XW-Bn for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:45:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrYB5-0006XO-2O for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:45:51 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52JjoQS025078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 2 Jun 2014 15:45:50 -0400 Message-ID: <538CD46D.1060905@redhat.com> Date: Mon, 02 Jun 2014 13:45:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401737518-14029-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1401737518-14029-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wHTFT15e7h6DoXjg9w5Mx2VOBat07rmM1" Subject: Re: [Qemu-devel] [PATCH] qemu-img: Document check exit codes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wHTFT15e7h6DoXjg9w5Mx2VOBat07rmM1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/02/2014 01:31 PM, Max Reitz wrote: > The exit code 63 (check not supported by image format) was not even > documented in the comment above the check command in the source code; > add it, as it does indeed seem useful. >=20 > Also, document all of check's exit codes in the manpage. >=20 > Signed-off-by: Max Reitz > Reported-by: Markus Armbruster > --- > qemu-img.c | 9 +++++---- > qemu-img.texi | 23 +++++++++++++++++++++++ > 2 files changed, 28 insertions(+), 4 deletions(-) > =20 > +In case the image does not have any inconsistencies, check exits with = @code{0}. > +Other exit codes indicate the kind of inconsistency found or if anothe= r error > +occured. The following table summarizes all exit codes of the check su= bcommand: s/occured/occurred/ > + > +If @code{-r} is specified, exit codes representing the image state ref= er to the > +state after (the attempt on) repairing it. That is, a successful @code= {-r all} Not sure if this reads better, but: s/attempt on/attempt at/ With the spelling fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wHTFT15e7h6DoXjg9w5Mx2VOBat07rmM1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjNRtAAoJEKeha0olJ0Nqz7sH/3gYpDR8CmmwRaNJSRaTAudw Uq9ZNwwVJWlWv5AXz0G6Ey9pSLMrqdI3MbGi5qZlP4VwXKNjrtlqbGZdtd8bpIc6 uVdKxMEXgFjQuHVgViRyw+1ZV7sSzG7bJPeBUXfvffXs9t8+OmQAhW5HbMtwDaM7 3nOcsy3xpHXVvmVbCI4KBTM8SX3rrp+T76XkXWv0tenb1ak/qs0b6wP87olatIM9 IuDBRunOR2ck+BBBBJn/4jwh4e6mxhk/Ll9b1yqhymkTrscr+tnSJqV80Ujb+98k ZwmLJnQSlf8PtCEjS3s1XjHwc4A88MRmkID7ai9Xi9R/htOn80ga1DaPJDy2V0o= =C8AZ -----END PGP SIGNATURE----- --wHTFT15e7h6DoXjg9w5Mx2VOBat07rmM1--