From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrYJ6-0003GL-Nk for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrYJ0-0000Wb-IM for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:54:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrYJ0-0000WE-AK for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:54:02 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52Js0on001066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Jun 2014 15:54:00 -0400 Message-ID: <538CD654.70303@redhat.com> Date: Mon, 02 Jun 2014 21:53:56 +0200 From: Max Reitz MIME-Version: 1.0 References: <1401737518-14029-1-git-send-email-mreitz@redhat.com> <538CD46D.1060905@redhat.com> In-Reply-To: <538CD46D.1060905@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-img: Document check exit codes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi On 02.06.2014 21:45, Eric Blake wrote: > On 06/02/2014 01:31 PM, Max Reitz wrote: >> The exit code 63 (check not supported by image format) was not even >> documented in the comment above the check command in the source code; >> add it, as it does indeed seem useful. >> >> Also, document all of check's exit codes in the manpage. >> >> Signed-off-by: Max Reitz >> Reported-by: Markus Armbruster >> --- >> qemu-img.c | 9 +++++---- >> qemu-img.texi | 23 +++++++++++++++++++++++ >> 2 files changed, 28 insertions(+), 4 deletions(-) >> >> +In case the image does not have any inconsistencies, check exits with @code{0}. >> +Other exit codes indicate the kind of inconsistency found or if another error >> +occured. The following table summarizes all exit codes of the check subcommand: > s/occured/occurred/ It's a bit embarrassing that the correct spelling was even part of the hunk environment. :-) >> + >> +If @code{-r} is specified, exit codes representing the image state refer to the >> +state after (the attempt on) repairing it. That is, a successful @code{-r all} > Not sure if this reads better, but: Yes, the sentence is kind of hard to read, but I couldn't think of a nicer expression (I could drop the "representing the image state" part, but then people might ask how this applies to code 63 -- but then again, it just doesn't make any sense for that code, so...). That's why I added the explanatory example following it. > s/attempt on/attempt at/ > > With the spelling fix, > Reviewed-by: Eric Blake Thank you, Max