qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH memory v2 7/9] memory: MemoryRegion: Add container and addr props
Date: Tue, 03 Jun 2014 09:51:41 +0200	[thread overview]
Message-ID: <538D7E8D.5060803@redhat.com> (raw)
In-Reply-To: <CAEgOgz5g=xyTHVJ2vDOPXbV2yop20JZMEmiFM2aFhx+=Pv=95A@mail.gmail.com>

Il 02/06/2014 04:40, Peter Crosthwaite ha scritto:
>> >  {
>> >      MemoryRegion *mr = MEMORY_REGION(obj);
>> > +    gchar *container_link_type = g_strdup_printf("link<%s>",
>> > +                                                 TYPE_MEMORY_REGION);
> Since TYPE_MEMORY_REGION is a literal string constant, this can be
> done with regular "" "" style string concatenation. Dropped the strdup
> in V3.

Note that object_resolve_path_component expects link<FOO> properties to 
have a LinkProperty stored in prop->opaque.  Does this hold in your case?

Perhaps we can instead add a new ->resolve function pointer to properties.

Paolo

  reply	other threads:[~2014-06-03  7:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1401181024.git.peter.crosthwaite@xilinx.com>
     [not found] ` <97326fc0f0043b379de507a55387ffd987138287.1401181024.git.peter.crosthwaite@xilinx.com>
     [not found]   ` <5384BC4C.7090407@redhat.com>
2014-06-02  2:11     ` [Qemu-devel] [PATCH memory v2 6/9] memory: MemoryRegion: QOMify Peter Crosthwaite
     [not found] ` <95099c6d2c53520148512094676ca637f53eabd6.1401181024.git.peter.crosthwaite@xilinx.com>
2014-06-02  2:40   ` [Qemu-devel] [PATCH memory v2 7/9] memory: MemoryRegion: Add container and addr props Peter Crosthwaite
2014-06-03  7:51     ` Paolo Bonzini [this message]
2014-06-03  8:52       ` Peter Crosthwaite
     [not found] ` <48f9598e46a7eb267e222b62085b91efd3bfb6db.1401181024.git.peter.crosthwaite@xilinx.com>
2014-06-02  2:44   ` [Qemu-devel] [PATCH memory v2 8/9] memory: MemoryRegion: Add may-overlap and priority props Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538D7E8D.5060803@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).