From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WrjVi-0004Iq-Mz
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 03:52:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WrjVc-0008DI-IO
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 03:51:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16487)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WrjVc-0008D2-Ab
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 03:51:48 -0400
Message-ID: <538D7E8D.5060803@redhat.com>
Date: Tue, 03 Jun 2014 09:51:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1401181024.git.peter.crosthwaite@xilinx.com>	<95099c6d2c53520148512094676ca637f53eabd6.1401181024.git.peter.crosthwaite@xilinx.com>
	<CAEgOgz5g=xyTHVJ2vDOPXbV2yop20JZMEmiFM2aFhx+=Pv=95A@mail.gmail.com>
In-Reply-To: <CAEgOgz5g=xyTHVJ2vDOPXbV2yop20JZMEmiFM2aFhx+=Pv=95A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH memory v2 7/9] memory: MemoryRegion: Add
 container and addr props
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 02/06/2014 04:40, Peter Crosthwaite ha scritto:
>> >  {
>> >      MemoryRegion *mr = MEMORY_REGION(obj);
>> > +    gchar *container_link_type = g_strdup_printf("link<%s>",
>> > +                                                 TYPE_MEMORY_REGION);
> Since TYPE_MEMORY_REGION is a literal string constant, this can be
> done with regular "" "" style string concatenation. Dropped the strdup
> in V3.

Note that object_resolve_path_component expects link<FOO> properties to 
have a LinkProperty stored in prop->opaque.  Does this hold in your case?

Perhaps we can instead add a new ->resolve function pointer to properties.

Paolo