From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrlCl-0003l9-5n for qemu-devel@nongnu.org; Tue, 03 Jun 2014 05:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrlCf-0005tL-0G for qemu-devel@nongnu.org; Tue, 03 Jun 2014 05:40:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrkwQ-0007ge-Bq for qemu-devel@nongnu.org; Tue, 03 Jun 2014 05:23:34 -0400 Message-ID: <538D9410.7060300@redhat.com> Date: Tue, 03 Jun 2014 11:23:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1401392813-29645-1-git-send-email-pbonzini@redhat.com> <1401392813-29645-5-git-send-email-pbonzini@redhat.com> <53882A9D.7010501@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers Il 02/06/2014 18:17, Peter Maydell ha scritto: > Um. This feels like we're wrongly overloading this flag for > more than one thing. "Is the user-mode binary BE8?" is > definitely not a property of the CPU, so it shouldn't be > a CPU state flag. (Conversely, "is the iside endianness the > opposite way round to TARGET_WORDS_BIGENDIAN" is a CPU > property of sorts.) It seems to me that we probably want > to fix this by more correctly modelling the actual CPU > state involved here, by having user-mode either set or > not set SCTLR.B [set only if BE32 binary], and the data > and insn fetches honour both that and CPSR.E appropriately.) So basically it's s/bswap_code/!sctlr_b/. Thanks for the suggestion! Paolo