From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36248)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wrn4n-0004h2-Nd
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 07:40:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wrn4f-00011I-Nx
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 07:40:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9535)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wrn4f-00011B-GU
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 07:40:13 -0400
Message-ID: <538DB407.3020904@redhat.com>
Date: Tue, 03 Jun 2014 13:39:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1401440369-29929-1-git-send-email-tiejun.chen@intel.com>
	<1401440369-29929-3-git-send-email-tiejun.chen@intel.com>
	<538D8B59.4070105@redhat.com>
	<alpine.DEB.2.02.1406031203340.4779@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1406031203340.4779@kaball.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v4][PATCH 2/5] xen,
	gfx passthrough: create intel isa bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, mst@redhat.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, allen.m.kay@intel.com, Kelly.Zytaruk@amd.com, Jan Beulich <JBeulich@novell.com>, qemu-devel@nongnu.org, yang.z.zhang@intel.com, Tim Deegan <tim@xen.org>, Anthony Liguori <anthony@codemonkey.ws>, anthony.perard@citrix.com, Tiejun Chen <tiejun.chen@intel.com>, George Dunlap <george.dunlap@citrix.com>, Konrad Rzeszutek Wilk <konrad@kernel.org>

Il 03/06/2014 13:29, Stefano Stabellini ha scritto:
>> It's really not your fault, there's not much you can do given the hardware
>> architecture.  But I don't think this code can be accepted upstream, sorry.
>
> Yeah, the code is not nice and it is not Tiejun's fault.
>
> Is there any way at all he could change the patch series to make it more
> appealing to you? Or maybe we could having more clearly separated from
> the rest of the codebase?

I don't know, perhaps a new "-M pc-xen-igd-passthrough" machine type 
based on what you're using now (pc-1.6?) but with all the required hacks?

Paolo