From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrqE2-0004vb-OB for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:02:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrqDx-0002iC-G0 for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:02:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrqDx-0002i5-6u for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:02:01 -0400 Message-ID: <538DE366.5090105@redhat.com> Date: Tue, 03 Jun 2014 09:01:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> <1401537111-10221-73-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401537111-10221-73-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="59MWFOKoLB7kuAesi25KWAT5P6GugBWXf" Subject: Re: [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --59MWFOKoLB7kuAesi25KWAT5P6GugBWXf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/31/2014 05:51 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 10 ---------- > qapi/block.json | 10 ++++++++++ > 2 files changed, 10 insertions(+), 10 deletions(-) 45-72: Reviewed-by: Eric Blake If you resend this series for any reason, PLEASE consolidate into fewer patches. As long as the types are copied out of qapi-schema.json in the same order that they are copied into block.json, it's much faster to review that the code motion was done correctly if there is only one such patch describing the motion to block.json than to read lots of tiny patches one per struct/command. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --59MWFOKoLB7kuAesi25KWAT5P6GugBWXf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjeNmAAoJEKeha0olJ0NqeoMIAKIU5Jod5ku4caaOCavnPMCQ oAjO3MoFYybi6V7Ll0lnkE4EjRTSZvhA5Xue+iz9cLGmmh0zwZ0Z83XgIdRBajiZ eQP4P+LH5f45DPjso39IuVo8MMkrES+f5PLo/A6moGNzHffmMyP8LLopZ03mazlT Q1igGw+cUJRnn/RT7p6B3enFYpIb1uCAR0cTmOfop0JyvpzAC685bB+BJ3VUC7mh iuhW63R+XXi/6bdxHoyyX+CMO7o/7s9jj7TBFWQrHVqOr05yMSaoDyyaIxz1RYq5 ETzDWBBSnY1g9PMI//eSI1Ax/GUvqJj1OJ/ZufArnmxnI9D3zZaj6EB2bvErONQ= =uMLr -----END PGP SIGNATURE----- --59MWFOKoLB7kuAesi25KWAT5P6GugBWXf--