From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrqT5-00039p-RN for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:17:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrqSx-0000sV-IM for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:17:39 -0400 Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:42625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrqSx-0000s2-EF for qemu-devel@nongnu.org; Tue, 03 Jun 2014 11:17:31 -0400 Received: by mail-qa0-f41.google.com with SMTP id dc16so5042065qab.14 for ; Tue, 03 Jun 2014 08:17:31 -0700 (PDT) Sender: Richard Henderson Message-ID: <538DE707.2050706@twiddle.net> Date: Tue, 03 Jun 2014 08:17:27 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1401782502-29772-1-git-send-email-kraxel@redhat.com> <1401782502-29772-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1401782502-29772-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] gtk: cleanup backend dependencies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Anthony Liguori On 06/03/2014 01:01 AM, Gerd Hoffmann wrote: > Make configure detect gtk x11 backend and link libX11 then. Make > gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* > backends at runtime). Our gtk ui code should build and run fine on > any platform now. > > This also fixes the linker failute due to the new XkbGetKeyboard call > added by commit 3158a3482b0093e41f2b2596fba50774ea31ae08. > > Cc: Richard Henderson > Signed-off-by: Gerd Hoffmann > Reviewed-by: Daniel P. Berrange > --- > configure | 4 ++++ > ui/gtk.c | 70 ++++++++++++++++++++++++++++++++++++++------------------------- > 2 files changed, 46 insertions(+), 28 deletions(-) Tested-by: Richard Henderson r~