From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrWd-0008LO-E4
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:25:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrWU-0002G8-78
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:25:23 -0400
Message-ID: <538DF6E6.6080607@gmail.com>
Date: Tue, 03 Jun 2014 11:25:10 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru>
	<1401787684-31895-3-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401787684-31895-3-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP
 into a single 970 class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> @@ -7303,8 +7304,21 @@ static void init_proc_970 (CPUPPCState *env)
>                   SPR_NOACCESS, SPR_NOACCESS,
>                   &spr_read_hior, &spr_write_hior,
>                   0x00000000);
> +
> +    spr_register(env, SPR_CTRL, "SPR_CTRL",
> +                 SPR_NOACCESS, SPR_NOACCESS,
> +                 SPR_NOACCESS, &spr_write_generic,
> +                 0x00000000);
> +    spr_register(env, SPR_UCTRL, "SPR_UCTRL",
> +                 SPR_NOACCESS, SPR_NOACCESS,
> +                 &spr_read_generic, SPR_NOACCESS,
> +                 0x00000000);

This doesn't look quite right .... UCTRL is readable also from both user & supervisor mode.

And UCTRL should alias CTRL (a la your read_ureg helper).

But you've only re-arranged existing code ... not regressed anything.  This should be fixed in
a follow up patch.