From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrgQ-0005B8-K9
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:35:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrgK-000697-KG
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:35:30 -0400
Message-ID: <538DF948.2080903@gmail.com>
Date: Tue, 03 Jun 2014 11:35:20 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru>
	<1401787684-31895-6-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401787684-31895-6-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 05/29] target-ppc: Add "POWER" prefix to
 MMCRA PMU registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> Since we started adding "POWER" prefix to 64bit PMU SPRs, let's finish
> the transition and fix MMCRA and define a hypv version of it.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

I'm still not a fan of "SPR_POWER_*" since these are now in the ISA (the "_POWER_" seems redundant).

Aside from that ...

Reviewed-by: Tom Musta <tommusta@gmail.com>