From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44907)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1Wrrnt-0005i9-2u
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:43:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1Wrrnm-00019L-Ok
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:43:13 -0400
Message-ID: <538DFB17.20703@gmail.com>
Date: Tue, 03 Jun 2014 11:43:03 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru>
	<1401787684-31895-9-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401787684-31895-9-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 08/29] target-ppc: Add HID4 SPR for
	PPC970
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> Previously LPCR was registered for the 970 class which was wrong as
> it does not have LPCR. Instead, HID4 is used which this patch registers.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/cpu.h            |  1 +
>  target-ppc/translate_init.c | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index fc09087..97f01ca 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -1683,6 +1683,7 @@ static inline int cpu_mmu_index (CPUPPCState *env)
>  #define SPR_750_TDCL          (0x3F4)
>  #define SPR_40x_IAC1          (0x3F4)
>  #define SPR_MMUCSR0           (0x3F4)
> +#define SPR_970_HID4          (0x3F4)
>  #define SPR_DABR              (0x3F5)
>  #define DABR_MASK (~(target_ulong)0x7)
>  #define SPR_Exxx_BUCSR        (0x3F5)
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 0fcf918..de920a0 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7301,6 +7301,16 @@ static void gen_spr_970_hior(CPUPPCState *env)
>                   0x00000000);
>  }
>  
> +static void gen_spr_970_lpar(CPUPPCState *env)
> +{
> +    /* Logical partitionning */
> +    /* PPC970: HID4 is effectively the LPCR */
> +    spr_register(env, SPR_970_HID4, "HID4",
> +                 SPR_NOACCESS, SPR_NOACCESS,
> +                 &spr_read_generic, &spr_write_generic,
> +                 0x00000000);
> +}
> +
>  static void gen_spr_book3s_common(CPUPPCState *env)
>  {
>      spr_register(env, SPR_CTRL, "SPR_CTRL",
> @@ -7490,6 +7500,7 @@ static void init_proc_970 (CPUPPCState *env)
>      gen_spr_book3s_common(env);
>      gen_spr_970_pmu_hypv(env);
>      gen_spr_970_pmu_user(env);
> +    gen_spr_970_lpar(env);
>  
>      gen_spr_power5p_ear(env);
>  
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>