From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrrqQ-0007y6-6f for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrrqK-0002s0-5g for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:45:50 -0400 Message-ID: <538DFBB4.3080502@gmail.com> Date: Tue, 03 Jun 2014 11:45:40 -0500 From: Tom Musta MIME-Version: 1.0 References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru> <1401787684-31895-11-git-send-email-aik@ozlabs.ru> In-Reply-To: <1401787684-31895-11-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 10/29] target-ppc: Remove check_pow_970FX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote: > After merging 970s into one class, check_pow_970() is used for all of them. > Since POWER5+ is no different in the matter of supported power modes, > let's use the same check_pow() callback for POWER5+ too, > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/translate_init.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 301f5ff..b372a64 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -7584,14 +7584,6 @@ POWERPC_FAMILY(970)(ObjectClass *oc, void *data) > pcc->l1_icache_size = 0x10000; > } > > -static int check_pow_970FX (CPUPPCState *env) > -{ > - if (env->spr[SPR_HID0] & 0x00600000) > - return 1; > - > - return 0; > -} > - > static void init_proc_power5plus(CPUPPCState *env) > { > init_proc_book3s_64(env, BOOK3S_CPU_POWER5PLUS); > @@ -7605,7 +7597,7 @@ POWERPC_FAMILY(POWER5P)(ObjectClass *oc, void *data) > dc->fw_name = "PowerPC,POWER5"; > dc->desc = "POWER5+"; > pcc->init_proc = init_proc_power5plus; > - pcc->check_pow = check_pow_970FX; > + pcc->check_pow = check_pow_970; > pcc->insns_flags = PPC_INSNS_BASE | PPC_STRING | PPC_MFTB | > PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > Reviewed-by: Tom Musta