From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1Wrrtd-0002mX-TO
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:49:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrtV-0003oJ-HC
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:49:09 -0400
Message-ID: <538DFC79.1080104@gmail.com>
Date: Tue, 03 Jun 2014 11:48:57 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru>
	<1401787684-31895-14-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401787684-31895-14-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 13/29] target-ppc: Move POWER8 TCE
 Address control (TAR) to a helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> This moves TAR SPR to a helper. Later this helper will be
> called from generalized init_proc_book3s_64().
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/translate_init.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index aa88727..d6557f2 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7523,6 +7523,14 @@ static void gen_spr_book3s_purr(CPUPPCState *env)
>  #endif
>  }
>  
> +static void gen_spr_power8_tce_address_control(CPUPPCState *env)
> +{
> +    spr_register(env, SPR_TAR, "TAR",
> +                 &spr_read_generic, &spr_write_generic,
> +                 &spr_read_generic, &spr_write_generic,
> +                 0x00000000);
> +}
> +
>  static void init_proc_book3s_64(CPUPPCState *env, int version)
>  {
>      gen_spr_ne_601(env);
> @@ -7933,11 +7941,7 @@ static void init_proc_POWER8(CPUPPCState *env)
>      /* inherit P7 */
>      init_proc_POWER7(env);
>  
> -    /* P8 supports the TAR */
> -    spr_register(env, SPR_TAR, "TAR",
> -                 &spr_read_generic, &spr_write_generic,
> -                 &spr_read_generic, &spr_write_generic,
> -                 0x00000000);
> +    gen_spr_power8_tce_address_control(env);
>  }
>  
>  POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data)
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>