From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrwPv-0003gA-EF for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:38:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrwPq-0000yy-I4 for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:38:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrwPq-0000ym-7v for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:38:42 -0400 Message-ID: <538E405B.2020204@redhat.com> Date: Tue, 03 Jun 2014 15:38:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140522135641.6110.28511.stgit@hds.com> <20140522135653.6110.79891.stgit@hds.com> <20140603212147.3985.99693@loki> In-Reply-To: <20140603212147.3985.99693@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ovvBQc1pctTCHI1nPmM4plgJmwMKOm0ou" Subject: Re: [Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ovvBQc1pctTCHI1nPmM4plgJmwMKOm0ou Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/03/2014 03:21 PM, Michael Roth wrote: > Quoting Tomoki Sekiyama (2014-05-22 08:56:53) >> When an array of mount point paths is specified as 'mountpoints' argum= ent >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the= file >> systems mounted on specified paths in Linux. >> This would be useful when the host wants to create partial disk snapsh= ots. >=20 > Since this isn't really applicable for win32, and it's hard to discover= > optional params via guest-info without some extensive changes to how we= handle > capabilities negotiation, I think it makes more sense to introduce a ne= w > command for this, something like guest-fsfreeze-freeze-filesystems, whi= ch we > can easily discover and properly mark as unsupported on win32. Bikeshedding on the proposed name: given that 'fs' is an abbreviation of 'filesystem', "fsfreeze-freeze-filesystems" sounds rather redundant. I would suggest guest-fsfreeze-list as a shorter name that conveys the intent, without quite as much repetition. >=20 > Other than that looks good. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ovvBQc1pctTCHI1nPmM4plgJmwMKOm0ou Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjkBbAAoJEKeha0olJ0NqICoH/15qafRnrmQb/ggSrZScgqxw XLpC3oIDAFhHntdkIIC57TVF1Xw5NLRkeMYmfrglLV55+5jL6sFGBOXFQ/rK157Z kVIo70aSmrdPcwCrJT2GpvdvO9TSKM1qwq/znF1CCT0jPj+cHPz5jNnUrm2obQP3 H4vU2vOjRxK1H3hzBsOmLKssJnilN8UIQ29Sg9wxVJkhFkR7VCtHP6XQjrmCWxBj iH1mu5E+w4OEDl14BRuyMeaz4xVsW1tuzoH4AQLHr+ig4mQKpuedSgXxMnpWZugX yAriop5PM5DOK7O/eOCc3vZ8CVC1Vfx6T2u0J7257II6gWN/F/0M/L6gke9qCjo= =98cu -----END PGP SIGNATURE----- --ovvBQc1pctTCHI1nPmM4plgJmwMKOm0ou--