From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrwvE-0003pa-Dm for qemu-devel@nongnu.org; Tue, 03 Jun 2014 18:11:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wrwv9-0003GD-1R for qemu-devel@nongnu.org; Tue, 03 Jun 2014 18:11:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrwv8-0003G2-PX for qemu-devel@nongnu.org; Tue, 03 Jun 2014 18:11:02 -0400 Message-ID: <538E47ED.2080100@redhat.com> Date: Tue, 03 Jun 2014 16:10:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140522135641.6110.28511.stgit@hds.com> <20140522135653.6110.79891.stgit@hds.com> <20140603212147.3985.99693@loki> <538E405B.2020204@redhat.com> <20140603215820.3985.70471@loki> <538E46DE.2000109@redhat.com> In-Reply-To: <538E46DE.2000109@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bmUBR4VFI9mcFu7cEDsN0CKWCmOK33sBx" Subject: Re: [Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bmUBR4VFI9mcFu7cEDsN0CKWCmOK33sBx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/03/2014 04:06 PM, Eric Blake wrote: > On 06/03/2014 03:58 PM, Michael Roth wrote: >=20 >>> Bikeshedding on the proposed name: given that 'fs' is an abbreviation= of >>> 'filesystem', "fsfreeze-freeze-filesystems" sounds rather redundant. = I >>> would suggest guest-fsfreeze-list as a shorter name that conveys the >>> intent, without quite as much repetition. >> >> Somewhat agree, though I think we should retain the guest-- >> structure and at least go with guest-fsfreeze-freeze-list. >=20 > guest- prefix is uncontroversial > command_group is 'fsfreeze'. > Currently in that group are the verbs 'status', 'freeze', and 'thaw'; > and my proposal is to add 'list' (not 'freeze-list') as the new verb > (just as we don't have 'freeze-status' as a verb). Uggh, now that I reread the thread... 'freeze-list' is indeed a better verb than 'list' - we aren't listing the mountpoints (that is patch 2/2 with guest-fs-get-info), but freezing a list of mountpoints (the existing 'freeze' action is taken, so we are doing a new action based on freeze but with a longer name). Okay, I can live with 'guest-fsfreeze-freeze-list'. Do we need a guest-fsfreeze-thaw-list counterpart, or is it sufficient to always thaw all systems without worrying about listing them? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bmUBR4VFI9mcFu7cEDsN0CKWCmOK33sBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjkfuAAoJEKeha0olJ0NqWbMH/Ao2q6LFatuD6dnnF8XuqddM yfluWpR5npHFRa06mCOpgbeRf1dfg7mLIabzwBPWK1RqhLjcjXxzme9Yw8rVKMR/ KgxT4Gmm4NPxC0SCdsjJi7ffgk7Ab7QjZp/3gqAlSskW6r8ucw7LADxxIpAIO2bw uZFrVYKBE2dj8TlJ9+SOFG+oyNY08nMDkME0v0zj7hTVURHezu7wHpGW1gYvPw45 cWlkMlKoua+QEUuoUrh8YoX5RgF8aen9MtV2LaLf7RT5HTh8p5BTa1OdkyLGS8fQ F3Q7RDt5sU7NHDQ8l0SLzwZA2k5pbAa6+GxcWsMHkKWcDqEJ16pIP/4FuqWijjU= =iJeH -----END PGP SIGNATURE----- --bmUBR4VFI9mcFu7cEDsN0CKWCmOK33sBx--