From: Paolo Bonzini <pbonzini@redhat.com>
To: Jidong Xiao <jidong.xiao@gmail.com>,
qemu-devel@nongnu.org, KVM <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000
Date: Wed, 04 Jun 2014 09:09:46 +0200 [thread overview]
Message-ID: <538EC63A.80405@redhat.com> (raw)
In-Reply-To: <CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com>
Il 04/06/2014 03:10, Jidong Xiao ha scritto:
> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c
> index 4389959..b8b282d 100644
> --- a/qemu-2.0.0/target-i386/kvm.c.orig
> +++ b/qemu-2.0.0/target-i386/kvm.c
> @@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> c = &cpuid_data.entries[cpuid_i++];
> c->function = KVM_CPUID_SIGNATURE | kvm_base;
> - c->eax = 0;
> + c->eax = KVM_CPUID_FEATURES;
> c->ebx = signature[0];
> c->ecx = signature[1];
> c->edx = signature[2];
This should actually be "KVM_CPUID_FEATURES | kvm_base", in case Hyper-V
leaves are available too. But it is a good catch!
Paolo
next prev parent reply other threads:[~2014-06-04 7:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 1:10 [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000 Jidong Xiao
2014-06-04 7:09 ` Paolo Bonzini [this message]
2014-06-04 7:17 ` Jidong Xiao
2014-06-04 19:08 ` Bandan Das
2014-06-04 19:47 ` Jidong Xiao
2014-06-04 21:26 ` Bandan Das
2014-08-12 18:55 ` Eduardo Habkost
2014-08-12 19:12 ` Paolo Bonzini
2014-08-12 19:29 ` Eduardo Habkost
2014-08-13 12:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538EC63A.80405@redhat.com \
--to=pbonzini@redhat.com \
--cc=jidong.xiao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).