From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47025)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ws5Kj-0000C9-0Y
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 03:10:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ws5KZ-00067F-Qr
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 03:10:00 -0400
Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:54421)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ws5KZ-000676-MT
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 03:09:51 -0400
Received: by mail-qa0-f41.google.com with SMTP id dc16so6559201qab.0
	for <qemu-devel@nongnu.org>; Wed, 04 Jun 2014 00:09:50 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <538EC63A.80405@redhat.com>
Date: Wed, 04 Jun 2014 09:09:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com>
In-Reply-To: <CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jidong Xiao <jidong.xiao@gmail.com>, qemu-devel@nongnu.org, KVM <kvm@vger.kernel.org>

Il 04/06/2014 03:10, Jidong Xiao ha scritto:
> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c
> index 4389959..b8b282d 100644
> --- a/qemu-2.0.0/target-i386/kvm.c.orig
> +++ b/qemu-2.0.0/target-i386/kvm.c
> @@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>      memcpy(signature, "KVMKVMKVM\0\0\0", 12);
>      c = &cpuid_data.entries[cpuid_i++];
>      c->function = KVM_CPUID_SIGNATURE | kvm_base;
> -    c->eax = 0;
> +   c->eax = KVM_CPUID_FEATURES;
>      c->ebx = signature[0];
>      c->ecx = signature[1];
>      c->edx = signature[2];

This should actually be "KVM_CPUID_FEATURES | kvm_base", in case Hyper-V 
leaves are available too.  But it is a good catch!

Paolo