From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws8Uq-0005Cf-Cx for qemu-devel@nongnu.org; Wed, 04 Jun 2014 06:32:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws8Uh-0003bn-BF for qemu-devel@nongnu.org; Wed, 04 Jun 2014 06:32:40 -0400 Message-ID: <538EF5A4.1030500@gmail.com> Date: Wed, 04 Jun 2014 18:32:04 +0800 From: Chen Gang MIME-Version: 1.0 References: <538C6F98.5070005@gmail.com> <871tv52ihw.fsf@blackfin.pond.sub.org> In-Reply-To: <871tv52ihw.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, QEMU Trivial , Michael Tokarev , dgilbert@redhat.com, QEMU Developers , owasserm@redhat.com, arei.gonglei@huawei.com On 06/04/2014 04:20 PM, Markus Armbruster wrote: > Chen Gang writes: > >> 'encoded_buf' and 'current_buf' are lock protected during using in >> save_xbzrle_page() in ram_save_page(), and during freeing in >> migration_end(). >> >> So recommend to let them lock protected during starting, just like we >> have done to 'cache'. > > I'd recommend against routing locking patches through -trivial. The > code has maintainers, and you cc'ed them. > OK, I shall remove -trivial for locking patches, next time. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed