From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1Ws9P9-000106-6u
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:31:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1Ws9P0-0001YO-1k
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:30:51 -0400
Message-ID: <538F0348.3090005@gmail.com>
Date: Wed, 04 Jun 2014 19:30:16 +0800
From: Chen Gang <gang.chen.5i5j@gmail.com>
MIME-Version: 1.0
References: <538C6B37.2030400@gmail.com>	<8761kh2iok.fsf@blackfin.pond.sub.org>
	<538EF4CC.8010703@gmail.com> <874n01vtan.fsf@blackfin.pond.sub.org>
In-Reply-To: <874n01vtan.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Free 'cache' in
 cache_fini() to avoid memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: quintela@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, dgilbert@redhat.com, owasserm@redhat.com, arei.gonglei@huawei.com

On 06/04/2014 06:54 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> On 06/04/2014 04:16 PM, Markus Armbruster wrote:
>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>
>>>> Call g_free() after cache_fini() in migration_end(), but do not call
>>>> g_free() after call cache_fini() in xbzrle_cache_resize() which will
>>>> cause memory leak.
>>>>
>>>> cache_init() and cache_fini() are pair, so need let cache_fini() call
>>>> g_free(cache) to match cache_init(), then fix current issue too.
>>>
>>> I'm not sure I get you.  Is the following accurate?
>>>
>>>     migration: Plug memory leak in migrate-set-cache-size command
>>>
>>>     We call g_free() after cache_fini() in migration_end(), but we don't
>>>     call it after cache_fini() in xbzrle_cache_resize(), leaking the
>>>     memory.
>>>
>>>     cache_init() and cache_fini() are a pair.  Since cache_init()
>>>     allocates the cache, let cache_fini() free it.  This plugs the leak.
>>>
>>
>> Yeah, and excuse me for my poor English.
> 
> No problem, we figured it out together :)
> 
> Would be nice to use the above text as commit message.  Perhaps it can
> be done on commit.
> 

That is fine to me.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed