From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WsAqK-0007Pm-14
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 09:03:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WsAqD-00007J-GH
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 09:02:59 -0400
Received: from averel.grnet-hq.admin.grnet.gr ([195.251.29.3]:7344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WsAqD-00006u-8y
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 09:02:53 -0400
Message-ID: <538F18DA.5090401@grnet.gr>
Date: Wed, 04 Jun 2014 16:02:18 +0300
From: Chrysostomos Nanakos <cnanakos@grnet.gr>
MIME-Version: 1.0
References: <1401881404-15823-1-git-send-email-cnanakos@grnet.gr>
	<1401881404-15823-4-git-send-email-cnanakos@grnet.gr>
	<538F1798.2000001@redhat.com>
In-Reply-To: <538F1798.2000001@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] QMP: Add support for Archipelago
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

On 06/04/2014 03:56 PM, Eric Blake wrote:
> On 06/04/2014 05:30 AM, Chrysostomos Nanakos wrote:
>> Introduce new enum BlockdevOptionsArchipelago.
>>
>> @volume:              #Name of the Archipelago volume image
>>
>> @mport:               #'mport' is the port number on which mapperd is
>>                        listening. This is optional and if not specified,
>>                        QEMU will make Archipelago to use the default port.
>>
>> @vport:               #'vport' is the port number on which vlmcd is
>>                        listening. This is optional and if not specified,
>>                        QEMU will make Archipelago to use the default port.
>>
>> Signed-off-by: Chrysostomos Nanakos <cnanakos@grnet.gr>
>> ---
>>   qapi-schema.json |   31 +++++++++++++++++++++++++++++--
>>   1 file changed, 29 insertions(+), 2 deletions(-)
>>
>> +
>> +##
>> +# @BlockdevOptionsArchipelago
>> +#
>> +# Driver specific block device options for Archipelago.
>> +#
>> +# @volume:              #Name of the Archipelago volume image
>> +#
> s/#Name/Name/ (we only use # for the initial comment, and for the
> special marking '#optional' that designates when a parameter is optional)
>
>> +#
>> +# @mport:               #'mport' is the port number on which mapperd is
>> +#                       listening. This is optional
>> +#                       and if not specified, QEMU will make Archipelago to
>> +#                       use the default port.
> @mport: #optional The port number ...
>
> s/to use/use/
>
>
>> +#
>> +# @vport:               #'vport' is the port number on which vlmcd is
>> +#                       listening. This is optional
>> +#                       and if not specified, QEMU will make Archipelago to
>> +#                       use the default port.
> @vport: #optional The port number...
>
> s/to use/use/
>
>> +# Since: 2.0
> 2.1
>
>> +##
>> +{ 'type': 'BlockdevOptionsArchipelago',
>> +  'data': { 'volume': 'str',
>> +            '*mport': 'int',
>> +            '*vport': 'int' } }
>> +
>>   ##
>>   # @BlkdebugEvent
>>   #
>> @@ -4616,6 +4642,7 @@
>>         'vhdx':       'BlockdevOptionsGenericFormat',
>>         'vmdk':       'BlockdevOptionsGenericCOWFormat',
>>         'vpc':        'BlockdevOptionsGenericFormat',
>> +      'archipelago': 'BlockdevOptionsArchipelago',
>>         'quorum':     'BlockdevOptionsQuorum'
>>     } }
>>   
>>

Fixed everything for v4 series.

Thanks!