From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WsEyl-0005uX-HD
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:28:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WsEyf-0004o3-46
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:27:59 -0400
Message-ID: <538F5712.6040907@gmail.com>
Date: Wed, 04 Jun 2014 12:27:46 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401886265-6589-1-git-send-email-aik@ozlabs.ru>
	<1401886265-6589-5-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401886265-6589-5-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 04/30] target-ppc: Make UCTRL a mirror
	of CTRL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, Greg Kurz <gkurz@linux.vnet.ibm.com>

On 6/4/2014 7:50 AM, Alexey Kardashevskiy wrote:
> This changes UCTRL SPR to read from its supermode copy.
> 
> This enables reading from UCTRL in user mode.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/translate_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 04497e4..8b83b28 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7308,8 +7308,8 @@ static void gen_spr_book3s_common(CPUPPCState *env)
>                   SPR_NOACCESS, &spr_write_generic,
>                   0x00000000);
>      spr_register(env, SPR_UCTRL, "SPR_UCTRL",
> -                 SPR_NOACCESS, SPR_NOACCESS,
> -                 &spr_read_generic, SPR_NOACCESS,
> +                 &spr_read_ureg, SPR_NOACCESS,
> +                 &spr_read_ureg, SPR_NOACCESS,
>                   0x00000000);
>  }
>  
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>