From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WsF18-0000pu-Ms
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:30:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WsF12-0006CF-F3
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:30:26 -0400
Message-ID: <538F57A5.2080708@gmail.com>
Date: Wed, 04 Jun 2014 12:30:13 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401886265-6589-1-git-send-email-aik@ozlabs.ru>
	<1401886265-6589-28-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401886265-6589-28-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 27/30] target-ppc: Enable PPR and VRSAVE
	SPRs migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, Greg Kurz <gkurz@linux.vnet.ibm.com>

On 6/4/2014 7:51 AM, Alexey Kardashevskiy wrote:
> This hooks SPR with theit "KVM set_one_reg" counterparts which enables
> their migration.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/translate_init.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 5326553..04390a5 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7399,10 +7399,10 @@ static void gen_spr_book3s_altivec(CPUPPCState *env)
>          return;
>      }
>  
> -    spr_register(env, SPR_VRSAVE, "SPR_VRSAVE",
> -                 &spr_read_generic, &spr_write_generic,
> -                 &spr_read_generic, &spr_write_generic,
> -                 0x00000000);
> +    spr_register_kvm(env, SPR_VRSAVE, "VRSAVE",
> +                     &spr_read_generic, &spr_write_generic,
> +                     &spr_read_generic, &spr_write_generic,
> +                     KVM_REG_PPC_VRSAVE, 0x00000000);
>  
>      /* Can't find information on what this should be on reset.  This
>       * value is the one used by 74xx processors. */
> @@ -7629,10 +7629,10 @@ static void gen_spr_power6_dbg(CPUPPCState *env)
>  
>  static void gen_spr_power5p_common(CPUPPCState *env)
>  {
> -    spr_register(env, SPR_PPR, "PPR",
> -                 &spr_read_generic, &spr_write_generic,
> -                 &spr_read_generic, &spr_write_generic,
> -                 0x00000000);
> +    spr_register_kvm(env, SPR_PPR, "PPR",
> +                     &spr_read_generic, &spr_write_generic,
> +                     &spr_read_generic, &spr_write_generic,
> +                     KVM_REG_PPC_PPR, 0x00000000);
>  }
>  
>  static void gen_spr_power6_common(CPUPPCState *env)
> 
Reviewed-by: Tom Musta <tommusta@gmail.com>