From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsIHs-0002zr-VA for qemu-devel@nongnu.org; Wed, 04 Jun 2014 17:00:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsIHl-0002Ed-4u for qemu-devel@nongnu.org; Wed, 04 Jun 2014 16:59:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsIHk-0002EN-SM for qemu-devel@nongnu.org; Wed, 04 Jun 2014 16:59:49 -0400 Message-ID: <538F88C0.509@redhat.com> Date: Wed, 04 Jun 2014 14:59:44 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XVULFGrxxfEGKLKMls4030UWbPKLrV7QS" Subject: Re: [Qemu-devel] [PATCH v4 04/10] block: make 'top' argument to block-commit optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XVULFGrxxfEGKLKMls4030UWbPKLrV7QS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/04/2014 07:51 AM, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. >=20 > Change it to optional, with the default being the active layer in the > device chain. >=20 > Reviewed-by: Eric Blake > Reviewed-by: Benoit Canet > Signed-off-by: Jeff Cody > --- Unrelated to my review, but I wish we had done a better job at making the qemu 2.0 addition of active commit introspectible. Had we made _this_ patch at the same time, introspection would be possible by creating a dummy blockdev, then attempting a block-commit that omits the 'top' argument (since the error message for a missing required argument [old qemu] is different than the message for a blockdev that can't be committed [new qemu]). But since this change is in a different release than where we supported active commit, I'm stuck coming up with some reliable way to do a probe of whether active commit is supported so that libvirt knows whether to expose active commit on to the end user. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XVULFGrxxfEGKLKMls4030UWbPKLrV7QS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTj4jAAAoJEKeha0olJ0NqCqEH/iB5eaL8uOQnGO7wODrBbRit tCrBSgf3ugBIYpVR+N2AUgpVMTgIri9UyUqtoYfRgtKmMzS4tF79Wm8jGTODQDkt U3KXptjCUcfGwuhxMYSXHH1exqbFRrIS65m6vecjGYzbnEgboTxQS37MFLiO7IEi x/X3WRtoqUmCn2uSIWUG0mERh1auambRL6BHY0Uom2wNyW70ctJebaq7ig2esqgS AuQxNU+LEsrRTJxMUoaxpD3VFzqVM6X0SZ03/tKCCXLzCM8LPGfxKFTN4TFUwR9G YwoWFiAjCpFS5yrKMtLwP0s+RmGHOtv/acqanlYdfpzO/BNiV4BcjZK6gVgFLCQ= =p7hB -----END PGP SIGNATURE----- --XVULFGrxxfEGKLKMls4030UWbPKLrV7QS--