From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsNZo-00077O-VU for qemu-devel@nongnu.org; Wed, 04 Jun 2014 22:38:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsNZk-0003Dr-26 for qemu-devel@nongnu.org; Wed, 04 Jun 2014 22:38:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsNZj-0003Dn-Pk for qemu-devel@nongnu.org; Wed, 04 Jun 2014 22:38:43 -0400 Message-ID: <538FD82F.3080904@redhat.com> Date: Wed, 04 Jun 2014 20:38:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <529e209cc358418f0a3569ed013d34932e691717.1401886089.git.jcody@redhat.com> In-Reply-To: <529e209cc358418f0a3569ed013d34932e691717.1401886089.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xHDQJn80k0cDiSgLjhUSGkLVWFHuq2Jdp" Subject: Re: [Qemu-devel] [PATCH v4 10/10] block: add QAPI command to allow live backing file change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xHDQJn80k0cDiSgLjhUSGkLVWFHuq2Jdp Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/04/2014 07:51 AM, Jeff Cody wrote: > This allows a user to make a live change to the backing file recorded i= n > an open image. >=20 > The image file to modify can be specified 2 ways: >=20 > 1) image filename > 2) image node-name >=20 > Note: this does not cause the backing file itself to be reopened; it > merely changes the backing filename in the image file structure, and > in internal BDS structures. >=20 > It is the responsibility of the user to pass a filename string that > can be resolved when the image chain is reopened, and the filename > string is not validated. >=20 > A good analogy for this command is that it is a live version of > 'qemu-img rebase -u', with respect to changing the backing file string.= >=20 > Signed-off-by: Jeff Cody > --- > blockdev.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qapi-schema.json | 60 ++++++++++++++++++++++++++++++++ > qmp-commands.hx | 74 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 236 insertions(+) >=20 > +# > +# Method 2 interface > +#--------------------- > +# @image-node-name #optional The name of the block driver state node o= f the > +# image to modify. The @device argumen is = used to s/argumen/argument/ Unless there is any other reason for a respin, I'm hoping the committer can fix the typo, and add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xHDQJn80k0cDiSgLjhUSGkLVWFHuq2Jdp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTj9gwAAoJEKeha0olJ0NqttIIAIuXbjLCHkC1tc4vNGKgCpVA XjTtluLsFa673HB819nJs28Oyj7ZoIq0P5XCltj7dOpQpfcCFLAVaVRHRV36H1yi Q5dblP63xWAjcptlYIArcXBYrfB2ZX1+rR9fh1OFW2r4+lljJRhX6PIIgUVUwi+/ sspqzjpP5bwVy+inusPDfn6xuQ0r/fo3d4ugpoXE02I0mIbTvLDzWrg0B8WS7X0c wsq8j0CFEQynBfR14Mqn31asQhvmVFpYl1CQUqETlrNdyGMFhhAa8qkiVRxTT2v6 Bvl5pizyysyio7BuJ69aEx387lN5KzSUq05BJHU3fNQ8XKSh/LqtUE32xggKeXU= =/ZU5 -----END PGP SIGNATURE----- --xHDQJn80k0cDiSgLjhUSGkLVWFHuq2Jdp--