From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
Date: Thu, 05 Jun 2014 06:09:32 +0200 [thread overview]
Message-ID: <538FED7C.3070000@redhat.com> (raw)
In-Reply-To: <20140605035042.GC10963@T430.nay.redhat.com>
Il 05/06/2014 05:50, Fam Zheng ha scritto:
>> > Can you try moving the req allocation and assignments inside process_request
>> > instead? Then you can fill in req->out directly without the struct
>> > assignment.
>> >
> The owners of req are do_rdwr_cmd and do_flush_cmd, but do_scsi_cmd and
> do_get_id_cmd don't need to allocate.
They don't need it, but using req there and freeing it in
complete_request_early perhaps could simplify the code.
After all, the first three arguments of complete_request_early (s, elem,
inhdr) are a duplicate of VirtIOBlockReq and do_flush_cmd is already
doing a free after complete_request_early.
Paolo
> Moving the allocation means transfering the ownership from process_request to
> respective cmd functions, and it's not used in two out of four. Not sure much
> better than this way, but that's doable.
next prev parent reply other threads:[~2014-06-05 4:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 1:58 [Qemu-devel] [PATCH v2 0/8] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 1/8] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 2/8] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 3/8] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 4/8] virtio-blk: Drop VirtIOBlockRequest.read Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 5/8] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq Fam Zheng
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 6/8] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr Fam Zheng
2014-06-05 2:51 ` Paolo Bonzini
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 7/8] virtio-blk: Convert VirtIOBlockReq.out to structrue Fam Zheng
2014-06-05 2:54 ` Paolo Bonzini
2014-06-05 1:58 ` [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code Fam Zheng
2014-06-05 2:55 ` Paolo Bonzini
2014-06-05 3:50 ` Fam Zheng
2014-06-05 4:09 ` Paolo Bonzini [this message]
2014-06-05 9:20 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538FED7C.3070000@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).