Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

[Thomas Huth <thuth@redhat.com>]

On 2019-01-31 18:56, Cornelia Huck wrote:
> On Thu, 31 Jan 2019 18:47:08 +0100
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> The arguments of the stub functions to not match the real implementation
> 
> s/to/do/

D'oh!

>> (and the prototypes in the header) anymore, so if you try to compile s390x
>> without CONFIG_PCI, the build currently fails.
>>
> 
> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")
> 
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  hw/s390x/s390-pci-stub.c | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> This file seems to be in danger of bitrot. Do you think it'll be easier
> to test rarely used configs like that after we switch to Kconfig?

I hope so, yes. There will be a new --without-default-devices options
for "configure" (which matches "make allnoconfig" from the kernel) - if
we do it right in the Kconfig file for s390x, it should be possible to
catch this problem with that option.

 Thomas