Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[Peter Lieven]

On 30.05.2014 11:05, Paolo Bonzini wrote:
> Il 30/05/2014 11:04, Peter Lieven ha scritto:
>> Am 30.05.2014 07:50, schrieb Paolo Bonzini:
>>> Il 29/05/2014 22:25, Peter Lieven ha scritto:
>>>> Am 29.05.2014 21:17, schrieb Paolo Bonzini:
>>>>> Il 29/05/2014 20:41, Peter Lieven ha scritto:
>>>>>> static inline unsigned geo_rand_range(double m, double n) {
>>>>>>     return exp((log(m) + (double)rand() /
>>>>>>                (RAND_MAX / (log(n) - log(m) + log(1)) + log(1))));
>>>>>> }
>>>>>
>>>>> Yes, exactly (except that log(1) is zero, and was only needed in your case because you were using integers).
>>>>
>>>> Regarding aio_timer_new vs. aio_timer_init. Shall we really have the complete QEMU_TIMER struct in each
>>>> iTask? We need this retry_timer only in the really rare case of a BUSY.
>>>
>>> Ok, makes sense.  Though the overall cost of IscsiTasks should be less than 4k per block device with a separate QemuTimer, and 8k if you embed it.
>>>
>>> Otherwise the patch looks good, thanks!
>>
>> Okay, when are you preparing the next pull request?
>
> After the dataplane patches go in.  But you can send the patch now, I'll rebase.

It might be that we need a LIBS+= -lm to the Makefile in the root directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.

Peter

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[Paolo Bonzini]

Il 05/06/2014 11:29, Peter Lieven ha scritto:
>
> It might be that we need a LIBS+= -lm to the Makefile in the root
> directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.

cat > $TMPC << EOF
#include <math.h>
int main(void) { return isnan(sin(0.0)); }
EOF
if compile_prog "" "" ; then
   :
elif compile_prog "" "-lm" ; then
   LIBS="-lm $LIBS"
   libs_qga="-lm $libs_qga"
else
   error_exit "libm check failed"
fi


Shouldn't be necessary, should it?

Paolo

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[Peter Lieven]

On 05.06.2014 11:44, Paolo Bonzini wrote:
> Il 05/06/2014 11:29, Peter Lieven ha scritto:
>>
>> It might be that we need a LIBS+= -lm to the Makefile in the root
>> directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.
>
> cat > $TMPC << EOF
> #include <math.h>
> int main(void) { return isnan(sin(0.0)); }
> EOF
> if compile_prog "" "" ; then
>   :
> elif compile_prog "" "-lm" ; then
>   LIBS="-lm $LIBS"
>   libs_qga="-lm $libs_qga"
> else
>   error_exit "libm check failed"
> fi
>
>
> Shouldn't be necessary, should it?

I don't know actually. On my workstation it compiles, but on my build system I need to add this here

diff --git a/Makefile b/Makefile
index 423e373..69e1022 100644
--- a/Makefile
+++ b/Makefile
@@ -74,6 +74,10 @@ $(call set-vpath, $(SRC_PATH))

  LIBS+=-lz $(LIBS_TOOLS)

+ifndef CONFIG_HAIKU
+LIBS+=-lm
+endif
+
  HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)

  ifdef BUILD_DOCS

Otherwise I get unresolved references to log and exp...

I found that the above is only in /x86_64-softmmu/Makefile, but  not in /Makefile

Peter

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

[George-Cristian Bîrzan]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

We're interested in this patch, is there an updated version (I'd rather not
try to fix the deprecated timer function myself), we can try? We have a
very easy way to reproduce this problem in Real Life (VMs connecting to a
scst target server) so if nothing else we can provide some testing. :)

-- 
George-Cristian Bîrzan

[-- Attachment #2: Type: text/html, Size: 385 bytes --]