From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46584)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WsUgQ-0004fz-2h
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:14:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WsUgH-0006cj-1G
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:14:06 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:44249 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WsUgG-0006cH-ML
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:13:56 -0400
Message-ID: <539042E0.6050603@kamp.de>
Date: Thu, 05 Jun 2014 12:13:52 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1401384704-14103-1-git-send-email-pl@kamp.de>	<538772C9.8080500@redhat.com>
	<53877F41.7090805@kamp.de>	<538787DC.10306@redhat.com>
	<5387979F.1070103@kamp.de> <53881C32.2040703@redhat.com>
	<5388498C.9040007@kamp.de> <538849D8.10806@redhat.com>
	<53903868.6070500@kamp.de> <53903BEF.9030706@redhat.com>
In-Reply-To: <53903BEF.9030706@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com, ronniesahlberg@gmail.com

On 05.06.2014 11:44, Paolo Bonzini wrote:
> Il 05/06/2014 11:29, Peter Lieven ha scritto:
>>
>> It might be that we need a LIBS+= -lm to the Makefile in the root
>> directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.
>
> cat > $TMPC << EOF
> #include <math.h>
> int main(void) { return isnan(sin(0.0)); }
> EOF
> if compile_prog "" "" ; then
>   :
> elif compile_prog "" "-lm" ; then
>   LIBS="-lm $LIBS"
>   libs_qga="-lm $libs_qga"
> else
>   error_exit "libm check failed"
> fi
>
>
> Shouldn't be necessary, should it?

I don't know actually. On my workstation it compiles, but on my build system I need to add this here

diff --git a/Makefile b/Makefile
index 423e373..69e1022 100644
--- a/Makefile
+++ b/Makefile
@@ -74,6 +74,10 @@ $(call set-vpath, $(SRC_PATH))

  LIBS+=-lz $(LIBS_TOOLS)

+ifndef CONFIG_HAIKU
+LIBS+=-lm
+endif
+
  HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)

  ifdef BUILD_DOCS

Otherwise I get unresolved references to log and exp...

I found that the above is only in /x86_64-softmmu/Makefile, but  not in /Makefile

Peter