From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WsUzg-00046P-BD
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:34:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WsUza-0006Mu-D8
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:34:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57888)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WsUza-0006Mp-4L
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 06:33:54 -0400
Message-ID: <5390478E.20805@redhat.com>
Date: Thu, 05 Jun 2014 12:33:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <86r433vr9a.fsf@lautaret.pauljanzen.org>
In-Reply-To: <86r433vr9a.fsf@lautaret.pauljanzen.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with
	-DDEBUG_SCSI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Janzen <pcj@pauljanzen.org>, qemu-devel@nongnu.org

Il 05/06/2014 07:33, Paul Janzen ha scritto:
> In scsi-disk.c, if you #define DEBUG_SCSI=1, you get:
> hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command':
> hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf'
>
> Change the debugging statement to match the actual value tested.
>
> Signed-off-by: Paul Janzen <pcj@pauljanzen.org>
> ---
>  hw/scsi/scsi-disk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 48a28ae..5ff4ae4 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2015,7 +2015,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
>      case VERIFY_10:
>      case VERIFY_12:
>      case VERIFY_16:
> -        DPRINTF("Verify (bytchk %lu)\n", (r->req.buf[1] >> 1) & 3);
> +        DPRINTF("Verify (bytchk %d)\n", (req->cmd.buf[1] >> 1) & 3);
>          if (req->cmd.buf[1] & 6) {
>              goto illegal_request;
>          }
>

Thanks, applied to scsi-next.

Paolo