* [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI
@ 2014-06-05 5:33 Paul Janzen
2014-06-05 10:33 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Paul Janzen @ 2014-06-05 5:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini
In scsi-disk.c, if you #define DEBUG_SCSI=1, you get:
hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command':
hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf'
Change the debugging statement to match the actual value tested.
Signed-off-by: Paul Janzen <pcj@pauljanzen.org>
---
hw/scsi/scsi-disk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 48a28ae..5ff4ae4 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2015,7 +2015,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
case VERIFY_10:
case VERIFY_12:
case VERIFY_16:
- DPRINTF("Verify (bytchk %lu)\n", (r->req.buf[1] >> 1) & 3);
+ DPRINTF("Verify (bytchk %d)\n", (req->cmd.buf[1] >> 1) & 3);
if (req->cmd.buf[1] & 6) {
goto illegal_request;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI
2014-06-05 5:33 [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI Paul Janzen
@ 2014-06-05 10:33 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-06-05 10:33 UTC (permalink / raw)
To: Paul Janzen, qemu-devel
Il 05/06/2014 07:33, Paul Janzen ha scritto:
> In scsi-disk.c, if you #define DEBUG_SCSI=1, you get:
> hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command':
> hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf'
>
> Change the debugging statement to match the actual value tested.
>
> Signed-off-by: Paul Janzen <pcj@pauljanzen.org>
> ---
> hw/scsi/scsi-disk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 48a28ae..5ff4ae4 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2015,7 +2015,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
> case VERIFY_10:
> case VERIFY_12:
> case VERIFY_16:
> - DPRINTF("Verify (bytchk %lu)\n", (r->req.buf[1] >> 1) & 3);
> + DPRINTF("Verify (bytchk %d)\n", (req->cmd.buf[1] >> 1) & 3);
> if (req->cmd.buf[1] & 6) {
> goto illegal_request;
> }
>
Thanks, applied to scsi-next.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-05 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 5:33 [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI Paul Janzen
2014-06-05 10:33 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).