From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsZkB-0002g0-Ri for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:38:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsZPX-0002tv-H7 for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:17:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsZPX-0002t7-3W for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:16:59 -0400 Message-ID: <539089E6.3070800@redhat.com> Date: Thu, 05 Jun 2014 09:16:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401968733-10998-1-git-send-email-benoit.canet@irqsave.net> <1401968733-10998-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401968733-10998-2-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="arDEq77kfP528suN0eWQRAchN1Awfx4WJ" Subject: Re: [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --arDEq77kfP528suN0eWQRAchN1Awfx4WJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 05:45 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 87 ++----------------------------------------------= ------ > qapi/common.json | 89 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 91 insertions(+), 85 deletions(-) > create mode 100644 qapi/common.json Reviewed-by: Eric Blake Much nicer. Here's the intra-diff showing that the motion is fairly straightforward: $ diff -u <(sed -n 's/^-//p' patch1) \ <(sed -n 's/^\+//p' patch1) --- /dev/fd/63 2014-06-05 09:15:37.189091311 -0600 +++ /dev/fd/62 2014-06-05 09:15:37.190091308 -0600 @@ -1,5 +1,11 @@ --- --- a/qapi-schema.json +++ b/qapi-schema.json +# QAPI common definitions +{ 'include': 'qapi/common.json' } +++ b/qapi/common.json +# -*- Mode: Python -*- +# +# QAPI common definitions + ## # @ErrorClass # @@ -26,6 +32,7 @@ 'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted', 'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] } +## # @VersionInfo: # # A description of QEMU's version. @@ -84,6 +91,3 @@ ## { 'command': 'query-commands', 'returns': ['CommandInfo'] } -## --- /dev/null --=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --arDEq77kfP528suN0eWQRAchN1Awfx4WJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTkInmAAoJEKeha0olJ0Nqr+QIAIEZQdqBLbEKhuU8ER+ZOOyB UVQiSWNlWVGNcxaJLB24ID+gihGf3Ll5ltyA0HGe5M8XewljiiDx6MyHZDDifRSV SqB4GbN4d2+VpCOJ+3aVHIWqlxVTgO4PQoucybwrjACDRdSGIZpZiujnVEhWjqFh 3C3b9Q1arepdX/KYtEvsPrguFNlkwDB5Gqt/TFHYD+cto1JhCU4wNdsQpEqey6hX hDm6ojIoQ+g6kqshYKCbSGrGaKSCoAAC5thfdvCDme79zF+P0qQ4LYB2HNd/8/HI +0JEzCMv897Xzwgn78XoALfxFQ1DhzjQu0wFpLp2zUMvVP8QZjhR57ggBejtU/w= =TPRL -----END PGP SIGNATURE----- --arDEq77kfP528suN0eWQRAchN1Awfx4WJ--