qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org
Cc: Riku Voipio <riku.voipio@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Tell guest about big host page sizes
Date: Thu, 05 Jun 2014 09:06:20 -0700	[thread overview]
Message-ID: <5390957C.3010405@twiddle.net> (raw)
In-Reply-To: <1401961383-28601-1-git-send-email-agraf@suse.de>

On 06/05/2014 02:43 AM, Alexander Graf wrote:
> We tell the guest its page size via AUX vectors. The guest process then uses
> this page size as information on which boundaries it can mmap() things.
> 
> However, if the host has a bigger page size granularity than the guest, it can
> not fulfill these mmap() requests - which falls apart when MAP_FIXED is passed
> to mmap.
> 
> So in that case, let the guest know that we're running on a bigger page size
> granularity than the target would require.
> 
> This fixes running qemu-ppc (TARGET_PAGE_SIZE=4k) on a 64k page size ppc64 host
> for me.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  linux-user/elfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Woot.  Obviously this won't fix all guests, only those that expect a variable
page size to begin.  But it's certainly a step forward.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

      reply	other threads:[~2014-06-05 16:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  9:43 [Qemu-devel] [PATCH] linux-user: Tell guest about big host page sizes Alexander Graf
2014-06-05 16:06 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5390957C.3010405@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).