From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WsaBk-0001CI-Eh
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:06:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WsaBd-0001Xs-Q1
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:06:48 -0400
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:2279)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WsaBd-0001Wi-J2
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:06:41 -0400
From: Don Slutz <dslutz@verizon.com>
Message-ID: <5390958D.1010402@terremark.com>
Date: Thu, 05 Jun 2014 12:06:37 -0400
MIME-Version: 1.0
References: <1399312987-29499-1-git-send-email-dslutz@verizon.com>
In-Reply-To: <1399312987-29499-1-git-send-email-dslutz@verizon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [ping PATCH v4 0/2] qdev: Display warning about
	unused -global
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

ping.

On 05/05/14 14:03, Don Slutz wrote:
> I might have named this v2, but since this is a split out of:
>
> [PATCH v3 2/4] GlobalProperty: Display warning about unused -global
>
> From:
>
> [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine option)
>
> I feel v4 is better.
>
> Changes v3 to v4:
>    Add a new patch to add a check in test-qdev-global-props.c
>    Changed qdev_prop_check_global() to return state.  Only used
>    by unit test.
>    Change to use error_report().
>
>    Andreas Färber:
>      Added hotpluggable checking.
>      Renamed to qdev:
>
>    Did not do:
>      Add a separate linked list:
>        This looked to me to increase the complexity without any benefit.
>      Adjust where vl.c calls qdev_prop_check_global().
>        Since this is just before migration starts, I still think this
>        is the best place.  I did a quick look into adding some test
>        that checks that this is still working, but only found qemu-iotest
>        doing the QEMU output check for expected output.  It did not
>        make sense to me to add a global property check there.
>
>    Paolo Bonzini:
>      Added a comment before definition of the not_used field.
>
>
>
> Don Slutz (2):
>    qdev: Display warning about unused -global
>    qdev: Add test of qdev_prop_check_global
>
>   hw/core/qdev-properties-system.c | 16 ++++++++++++++++
>   hw/core/qdev-properties.c        | 18 ++++++++++++++++++
>   include/hw/qdev-core.h           |  8 ++++++++
>   include/hw/qdev-properties.h     |  1 +
>   tests/test-qdev-global-props.c   |  4 ++++
>   vl.c                             |  2 ++
>   6 files changed, 49 insertions(+)
>