From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsakt-0000Xq-B0 for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:43:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsako-0000tX-A1 for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsako-0000tK-1T for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:43:02 -0400 Message-ID: <53909E10.9020300@redhat.com> Date: Thu, 05 Jun 2014 10:42:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401968733-10998-1-git-send-email-benoit.canet@irqsave.net> <1401968733-10998-4-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401968733-10998-4-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45n4x8n9rxjxIbkFKP5gbrvCuSokW6gXx" Subject: Re: [Qemu-devel] [PATCH v2 3/5] qapi: Extract qapi/block-core.json definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --45n4x8n9rxjxIbkFKP5gbrvCuSokW6gXx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 05:45 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet --- > qapi-schema.json | 1428 +-----------------------------------------= -------- > qapi/block-core.json | 1406 ++++++++++++++++++++++++++++++++++++++++++= +++++++ > 2 files changed, 1417 insertions(+), 1417 deletions(-) Intra-diff for reference. It mostly shows that the tweaks you made got git a bit confused; since 'git diff --patience' shows a smaller diffstat = of: qapi-schema.json | 1406 -------------------------------------------------- qapi/block-core.json | 1406 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 1406 insertions(+), 1406 deletions(-) and therefore your larger stat on qapi-schema.json was due to 'git diff' picking some lines as deletions and reinsertions instead of context to a larger chunk of moved text. Since I was able to apply the patch and run the patience algorithm, I'm confident your code motion was clean. Reviewed-by: Eric Blake $ diff -u <(sed -n 's/^-//p' patch3) \ <(sed -n 's/^\+//p' patch3) --- /dev/fd/63 2014-06-05 10:33:52.056307499 -0600 +++ /dev/fd/62 2014-06-05 10:33:52.057307497 -0600 @@ -1,5 +1,18 @@ --- --- a/qapi-schema.json +++ b/qapi-schema.json +# Since: 0.14.0 +# Notes: This command only exists as a stop-gap. Its use is highly +# discouraged. The semantics of this command are not guaranteed.= +# Known limitations: +# o This command is stateless, this means that commands that depe= nd +# on state information (such as getfd) might not work +# o Commands that prompt the user for data (eg. 'cont' when the block +# device is encrypted) don't currently work +{ 'command': 'human-monitor-command', + 'data': {'command-line': 'str', '*cpu-index': 'int'}, + 'returns': 'str' } +++ b/qapi/block-core.json + +## # @SnapshotInfo # # @id: unique snapshot id @@ -674,24 +687,6 @@ 'data': 'BlockdevSnapshot' } ## -# Since: 0.14.0 -# -# Notes: This command only exists as a stop-gap. Its use is highly -# discouraged. The semantics of this command are not guaranteed.= -# -# Known limitations: -# -# o This command is stateless, this means that commands that depe= nd -# on state information (such as getfd) might not work -# -# o Commands that prompt the user for data (eg. 'cont' when the block -# device is encrypted) don't currently work -## -{ 'command': 'human-monitor-command', - 'data': {'command-line': 'str', '*cpu-index': 'int'}, - 'returns': 'str' } - -## # @block-commit # # Live commit of data from overlay image nodes into backing nodes - i.e.= , @@ -793,21 +788,28 @@ # # @buf-size: #optional maximum amount of data in flight from source to # target (since 1.4). +# # @on-source-error: #optional the action to take on an error on the source, # default 'report'. 'stop' and 'enospc' can only be used # if the block device supports io-status (see BlockInfo). +# # @on-target-error: #optional the action to take on an error on the target, # default 'report' (no limitations, since this applies to # a different block device than @device). +# # Returns: nothing on success # If @device is not a valid block device, DeviceNotFound +# # Since 1.3 +## { 'command': 'drive-mirror', 'data': { 'device': 'str', 'target': 'str', '*format': 'str', 'sync': 'MirrorSyncMode', '*mode': 'NewImageMode', '*speed': 'int', '*granularity': 'uint32', '*buf-size': 'int', '*on-source-error': 'BlockdevOnError', '*on-target-error': 'BlockdevOnError' } } + +## # @block_set_io_throttle: # # Change I/O throttle limits for a block drive. @@ -1013,8 +1015,6 @@ { 'command': 'block-job-complete', 'data': { 'device': 'str' } } ## - -## # @BlockdevDiscardOptions # # Determines how to handle discard requests. @@ -1417,5 +1417,3 @@ ## { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } } --- a/qapi/block-core.json --=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --45n4x8n9rxjxIbkFKP5gbrvCuSokW6gXx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTkJ4QAAoJEKeha0olJ0NqUNMH/iS4em5My7dXvG9e2b8TEjrf fyJSQiID25zCvf0xj+yg8XuYQor/nuz7g3mkQboqoeqOAx/r2dfSHqNaynkNz2wM OMD1GPDENFvvAQ6M9yZrWguHkv83CuEi51eM8YLo2L1BYOuBUS0XKrdlY/SaZYC9 Kma3b2ofySv8TxRl8xql2BDSpUGjR1w82bq98pghyI78RjaJVpQAHCOsowm70bR4 E0bX/2mfe8vOpJGapSja0O6Vj6mZGKAhggJtd43DAaqRMN8os3in1H6IoiVhlXaK NrYNy5lyMVlSCe6xeId7CVvbUIiJuL+lHwzkwWLSK7QR9uvPvEwQ9Vu2OWPGhL8= =cqhL -----END PGP SIGNATURE----- --45n4x8n9rxjxIbkFKP5gbrvCuSokW6gXx--