* Re: [Qemu-devel] [PATCH] macio: Fix timer endianness
[not found] <1401148882-5838-1-git-send-email-agraf@suse.de>
@ 2014-06-05 20:43 ` Mark Cave-Ayland
0 siblings, 0 replies; only message in thread
From: Mark Cave-Ayland @ 2014-06-05 20:43 UTC (permalink / raw)
To: Alexander Graf, qemu-devel; +Cc: John Arbuckle, qemu-ppc
On 27/05/14 01:01, Alexander Graf wrote:
> The timer registers on our KeyLargo macio emulation are read as byte reversed
> from the big endian guest, so we better expose them endian reversed as well.
>
> This fixes initial hickups of booting Mac OS X with -M mac99 for me.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> hw/misc/macio/macio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
> index 7f99aa0..47f45f5 100644
> --- a/hw/misc/macio/macio.c
> +++ b/hw/misc/macio/macio.c
> @@ -259,7 +259,7 @@ static uint64_t timer_read(void *opaque, hwaddr addr, unsigned size)
> static const MemoryRegionOps timer_ops = {
> .read = timer_read,
> .write = timer_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static int macio_newworld_initfn(PCIDevice *d)
Amazing! This patch appears to fix booting my Darwin 8.01 test ISO with
-M mac99 so it now gets to the installer - nice work!
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-05 20:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1401148882-5838-1-git-send-email-agraf@suse.de>
2014-06-05 20:43 ` [Qemu-devel] [PATCH] macio: Fix timer endianness Mark Cave-Ayland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).