From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsfKv-0004Q2-0h for qemu-devel@nongnu.org; Thu, 05 Jun 2014 17:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsfKo-0002eX-Rb for qemu-devel@nongnu.org; Thu, 05 Jun 2014 17:36:36 -0400 Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:24465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsfKo-0002eF-GI for qemu-devel@nongnu.org; Thu, 05 Jun 2014 17:36:30 -0400 From: Don Slutz Message-ID: <5390E2D0.7070303@terremark.com> Date: Thu, 05 Jun 2014 17:36:16 -0400 MIME-Version: 1.0 References: <1401715529-636-1-git-send-email-imammedo@redhat.com> <1401715529-636-6-git-send-email-imammedo@redhat.com> In-Reply-To: <1401715529-636-6-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 05/33] add memdev backend infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com This change fails to pass "make check" for me: dcs-xen-54:~/qemu/out>rm -rf *;../configure --enable-debug --disable-pie --enable-trace-backend=stderr;make -j8 && make check && make check-block && echo ok ... GTESTER check-qtest-sh4eb GTESTER check-qtest-sparc Registering `memory' which already exists socket_accept failed: Resource temporarily unavailable ** ERROR:/home/don/qemu/tests/libqtest.c:189:qtest_init: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) make: *** [check-qtest-sparc] Error 1 dcs-xen-54:~/qemu>git-bisect bad 18e673e5a3f549671b345a778a84de5f0777e6bf is the first bad commit commit 18e673e5a3f549671b345a778a84de5f0777e6bf Author: Igor Mammedov Date: Wed Dec 11 13:19:20 2013 +0100 add memdev backend infrastructure Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that affects memory_region_init_ram(). Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- v5: - drop default 'complete' method, allowing child not to implement it - codestyle cleanups v4: - don't use nonexisting anymore error_is_set() v3: - fix path leak & use object_get_canonical_path_component() for getting object name v2: - reuse UserCreatable interface instead of custom callbacks :040000 040000 7af148ee7e1a49b04749a4d8261b13f208ac69e2 6e17d4ee053ab73ed6268ee0af358c545f7d48f7 M backends :040000 040000 8c80a6fa88899769dd98319142bacce811ed9378 6d11a9e95270aa80f70a1cb7045fb57113b21458 M include -Don Slutz On 06/02/14 09:25, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. > > Initially only legacy RAM backend is provided, which > uses memory_region_init_ram() allocator and compatible > with every CLI option that affects memory_region_init_ram(). > > Signed-off-by: Igor Mammedov > Signed-off-by: Paolo Bonzini > --- > v5: > - drop default 'complete' method, allowing child not to implement it > - codestyle cleanups > v4: > - don't use nonexisting anymore error_is_set() > v3: > - fix path leak & use object_get_canonical_path_component() > for getting object name > v2: > - reuse UserCreatable interface instead of custom callbacks > --- > backends/Makefile.objs | 2 + > backends/hostmem-ram.c | 54 +++++++++++++++++++++++++ > backends/hostmem.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++ > include/sysemu/hostmem.h | 60 ++++++++++++++++++++++++++++ > 4 files changed, 213 insertions(+), 0 deletions(-) > create mode 100644 backends/hostmem-ram.c > create mode 100644 backends/hostmem.c > create mode 100644 include/sysemu/hostmem.h > > diff --git a/backends/Makefile.objs b/backends/Makefile.objs > index 591ddcf..7fb7acd 100644 > --- a/backends/Makefile.objs > +++ b/backends/Makefile.objs > @@ -6,3 +6,5 @@ common-obj-$(CONFIG_BRLAPI) += baum.o > baum.o-cflags := $(SDL_CFLAGS) > > common-obj-$(CONFIG_TPM) += tpm.o > + > +common-obj-y += hostmem.o hostmem-ram.o > diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c > new file mode 100644 > index 0000000..6c52ddc > --- /dev/null > +++ b/backends/hostmem-ram.c > @@ -0,0 +1,54 @@ > +/* > + * QEMU Host Memory Backend > + * > + * Copyright (C) 2013-2014 Red Hat Inc > + * > + * Authors: > + * Igor Mammedov > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > +#include "sysemu/hostmem.h" > +#include "qom/object_interfaces.h" > + > +#define TYPE_MEMORY_BACKEND_RAM "memory-ram" > + > + > +static void > +ram_backend_memory_init(UserCreatable *uc, Error **errp) > +{ > + HostMemoryBackend *backend = MEMORY_BACKEND(uc); > + char *path; > + > + if (!backend->size) { > + error_setg(errp, "can't create backend with size 0"); > + return; > + } > + > + path = object_get_canonical_path_component(OBJECT(backend)); > + memory_region_init_ram(&backend->mr, OBJECT(backend), path, > + backend->size); > + g_free(path); > +} > + > +static void > +ram_backend_class_init(ObjectClass *oc, void *data) > +{ > + UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); > + > + ucc->complete = ram_backend_memory_init; > +} > + > +static const TypeInfo ram_backend_info = { > + .name = TYPE_MEMORY_BACKEND_RAM, > + .parent = TYPE_MEMORY_BACKEND, > + .class_init = ram_backend_class_init, > +}; > + > +static void register_types(void) > +{ > + type_register_static(&ram_backend_info); > +} > + > +type_init(register_types); > diff --git a/backends/hostmem.c b/backends/hostmem.c > new file mode 100644 > index 0000000..2f578ac > --- /dev/null > +++ b/backends/hostmem.c > @@ -0,0 +1,97 @@ > +/* > + * QEMU Host Memory Backend > + * > + * Copyright (C) 2013-2014 Red Hat Inc > + * > + * Authors: > + * Igor Mammedov > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > +#include "sysemu/hostmem.h" > +#include "sysemu/sysemu.h" > +#include "qapi/visitor.h" > +#include "qapi/qmp/qerror.h" > +#include "qemu/config-file.h" > +#include "qom/object_interfaces.h" > + > +static void > +hostmemory_backend_get_size(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > + HostMemoryBackend *backend = MEMORY_BACKEND(obj); > + uint64_t value = backend->size; > + > + visit_type_size(v, &value, name, errp); > +} > + > +static void > +hostmemory_backend_set_size(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > + HostMemoryBackend *backend = MEMORY_BACKEND(obj); > + Error *local_err = NULL; > + uint64_t value; > + > + if (memory_region_size(&backend->mr)) { > + error_setg(&local_err, "cannot change property value"); > + goto out; > + } > + > + visit_type_size(v, &value, name, &local_err); > + if (local_err) { > + goto out; > + } > + if (!value) { > + error_setg(&local_err, "Property '%s.%s' doesn't take value '%" > + PRIu64 "'", object_get_typename(obj), name, value); > + goto out; > + } > + backend->size = value; > +out: > + error_propagate(errp, local_err); > +} > + > +static void hostmemory_backend_init(Object *obj) > +{ > + object_property_add(obj, "size", "int", > + hostmemory_backend_get_size, > + hostmemory_backend_set_size, NULL, NULL, NULL); > +} > + > +static void hostmemory_backend_finalize(Object *obj) > +{ > + HostMemoryBackend *backend = MEMORY_BACKEND(obj); > + > + if (memory_region_size(&backend->mr)) { > + memory_region_destroy(&backend->mr); > + } > +} > + > +MemoryRegion * > +host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp) > +{ > + return memory_region_size(&backend->mr) ? &backend->mr : NULL; > +} > + > +static const TypeInfo hostmemory_backend_info = { > + .name = TYPE_MEMORY_BACKEND, > + .parent = TYPE_OBJECT, > + .abstract = true, > + .class_size = sizeof(HostMemoryBackendClass), > + .instance_size = sizeof(HostMemoryBackend), > + .instance_init = hostmemory_backend_init, > + .instance_finalize = hostmemory_backend_finalize, > + .interfaces = (InterfaceInfo[]) { > + { TYPE_USER_CREATABLE }, > + { } > + } > +}; > + > +static void register_types(void) > +{ > + type_register_static(&hostmemory_backend_info); > +} > + > +type_init(register_types); > diff --git a/include/sysemu/hostmem.h b/include/sysemu/hostmem.h > new file mode 100644 > index 0000000..6899fc3 > --- /dev/null > +++ b/include/sysemu/hostmem.h > @@ -0,0 +1,60 @@ > +/* > + * QEMU Host Memory Backend > + * > + * Copyright (C) 2013-2014 Red Hat Inc > + * > + * Authors: > + * Igor Mammedov > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > +#ifndef QEMU_RAM_H > +#define QEMU_RAM_H > + > +#include "qom/object.h" > +#include "qapi/error.h" > +#include "exec/memory.h" > +#include "qemu/option.h" > + > +#define TYPE_MEMORY_BACKEND "memory" > +#define MEMORY_BACKEND(obj) \ > + OBJECT_CHECK(HostMemoryBackend, (obj), TYPE_MEMORY_BACKEND) > +#define MEMORY_BACKEND_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(HostMemoryBackendClass, (obj), TYPE_MEMORY_BACKEND) > +#define MEMORY_BACKEND_CLASS(klass) \ > + OBJECT_CLASS_CHECK(HostMemoryBackendClass, (klass), TYPE_MEMORY_BACKEND) > + > +typedef struct HostMemoryBackend HostMemoryBackend; > +typedef struct HostMemoryBackendClass HostMemoryBackendClass; > + > +/** > + * HostMemoryBackendClass: > + * @parent_class: opaque parent class container > + */ > +struct HostMemoryBackendClass { > + ObjectClass parent_class; > +}; > + > +/** > + * @HostMemoryBackend > + * > + * @parent: opaque parent object container > + * @size: amount of memory backend provides > + * @id: unique identification string in memdev namespace > + * @mr: MemoryRegion representing host memory belonging to backend > + */ > +struct HostMemoryBackend { > + /* private */ > + Object parent; > + > + /* protected */ > + uint64_t size; > + > + MemoryRegion mr; > +}; > + > +MemoryRegion *host_memory_backend_get_memory(HostMemoryBackend *backend, > + Error **errp); > + > +#endif