From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsg8F-0002yB-Kh for qemu-devel@nongnu.org; Thu, 05 Jun 2014 18:27:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsg8B-0003Lc-6n for qemu-devel@nongnu.org; Thu, 05 Jun 2014 18:27:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsg8A-0003LW-Sr for qemu-devel@nongnu.org; Thu, 05 Jun 2014 18:27:31 -0400 Message-ID: <5390EECE.1060302@redhat.com> Date: Thu, 05 Jun 2014 16:27:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399456738-11132-1-git-send-email-cyliu@suse.com> <1399456738-11132-21-git-send-email-cyliu@suse.com> In-Reply-To: <1399456738-11132-21-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3qFIE9iv5LUk9EW2J7KFDrJCgj3s7Fjg" Subject: Re: [Qemu-devel] [PATCH v27 20/33] qcow2.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: l@dorileo.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u3qFIE9iv5LUk9EW2J7KFDrJCgj3s7Fjg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2014 03:58 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > Changes: > * remove exporting qemu_opt_find from qcow2 patch and commit separate= ly. > * remove unnecessary indention changes in bdrv_qcow2 as Eric points o= ut. >=20 > block/qcow2.c | 261 +++++++++++++++++++++++++++++++-------------------= -------- > 1 file changed, 139 insertions(+), 122 deletions(-) >=20 > } else { > - fprintf(stderr, "Unknown compatibility level %s.\n", > - options[i].value.s); > + fprintf(stderr, "Unknown compatibility level %s.\n", c= ompat); Not your fault this is using fprintf instead of error_report. But may be worth a followup patch to start converting this file to use common error reporting practices. Since this suggestion doesn't affect the validaty of this series... Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --u3qFIE9iv5LUk9EW2J7KFDrJCgj3s7Fjg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTkO7OAAoJEKeha0olJ0Nq/LsH/39V3ikCSW9MakfKhO/r6QTM 3nCbjtTrRVgeMlpFHpcLS/JK8J601r7+TLupfbe2zbKygku2oPMmwo6SgmQUWYdl tuz6LUDnwM05G6qhPhF0qSpO56H8wzu8iMaayztMDjq3YvLfxMzr2Ole17ltFYby C80inW1bva2Lz27OeD6OKA7pNz/dsgbaBrAHOuVy58Qi44u7F5+qFJiZb644G4AC c1aygjw9kMeksa3wM2GSQpvXa2sdFACH20vmhAz30HnjccP+jJ0FwctONeARde+n kNow6H/phl0wp3GbjePmR5lD6J/2EDTbNylXQKPueKPx+lQYlHhHYbq7tgzh7ZI= =ReYT -----END PGP SIGNATURE----- --u3qFIE9iv5LUk9EW2J7KFDrJCgj3s7Fjg--