From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsgi3-00061u-DJ for qemu-devel@nongnu.org; Thu, 05 Jun 2014 19:04:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsghy-0007LU-GW for qemu-devel@nongnu.org; Thu, 05 Jun 2014 19:04:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsghy-0007LO-6x for qemu-devel@nongnu.org; Thu, 05 Jun 2014 19:04:30 -0400 Message-ID: <5390F776.50706@redhat.com> Date: Thu, 05 Jun 2014 17:04:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402007340-26467-1-git-send-email-sbruno@freebsd.org> <1402007340-26467-6-git-send-email-sbruno@freebsd.org> In-Reply-To: <1402007340-26467-6-git-send-email-sbruno@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4fFbwPpC5TmfOHMlLmdtxm5Sji4KSUDFo" Subject: Re: [Qemu-devel] [PATCH 5/9 v2] Add print_sysarch() to out table of syscalls that are supported and support them on all architectures for freebsd. netbsd and openbsd are not implemented but stubbed out. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sean Bruno , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4fFbwPpC5TmfOHMlLmdtxm5Sji4KSUDFo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 04:28 PM, Sean Bruno wrote: In the subject, s/out/our/ ? Please trim your subject lines to 60 characters or so; and also include a topic. If you have more information (and that is often the case), then include a blank line after the summary before providing it. Thus, your commit should look more like: bsd: add print_sysarch() as supported syscall Add print_sysarch() to the table of syscalls that are supported, and support them on all architectures for freebsd. netbsd and openbsd are not implemented but stubbed out. > Signed-off-by: Sean Bruno > --- For more hints on writing a good subject, look at 'git shortlog -30', and read http://wiki.qemu.org/Contribute/SubmitAPatch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4fFbwPpC5TmfOHMlLmdtxm5Sji4KSUDFo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJTkPd2AAoJEKeha0olJ0Nq7+kH9isd2NpA82Y3eLFeEaYfE2m7 PQalLlkuD1tg1ly6ieHu56raDFqgeUwIytr7qDJmQ46/zVlleqgdQAY9BGEIwZ3n jO5IA5wGokz1tWiSfKEN8I9Xeq6isP2QLlAEl71iqloKLOrEzUoZ+qKevzh9Wojl 4DYxjg2cccubmUnGHRLzV+U09+CAtbBmzXBFhkr6ZFFkaOvUTOqSVGHknvt4tl5X Xq/HkP7Ppam36EsX417NyU+Qi9+THUYWDexaditkOBa2M8gX6gvuxwxQmepU7vIX rABFnuvK61icA/kHB4VYJVwUpd66TBck7sZBrpIn3z/rm33/q0tfciS9V1RaPw== =uXzS -----END PGP SIGNATURE----- --4fFbwPpC5TmfOHMlLmdtxm5Sji4KSUDFo--