From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wso2J-0002XA-92
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wso2B-0008D2-RI
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:53:59 -0400
Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:44981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wso2B-0008Cy-Lc
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:53:51 -0400
Received: by mail-qa0-f42.google.com with SMTP id j5so3086966qaq.29
	for <qemu-devel@nongnu.org>; Thu, 05 Jun 2014 23:53:51 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5391657B.8090506@redhat.com>
Date: Fri, 06 Jun 2014 08:53:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402019610-2985-1-git-send-email-famz@redhat.com>
In-Reply-To: <1402019610-2985-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge
	VirtIOBlockRequest into VirtIOBlockReq
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Il 06/06/2014 03:53, Fam Zheng ha scritto:
> This unifies the request structure used by dataplane and non-dataplane code,
> while dropping unnessary fields for bounce buffer and read flag.
>
> Applies on top of Stefan's block tree.
>
> v3: Address Paolo's comments:
>
> [06/09] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>         Add assertion and comments on inhdr.
>         Fix the offset and iov_discard_back.
>
> [08/09] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>         Allocate req in process_request.
>
> [09/09] virtio-blk: Fix and clean up the in_sg and out_sg check
>         New.
>
>
>
> Fam Zheng (9):
>   virtio-blk: Move VirtIOBlockReq to header
>   virtio-blk: Convert VirtIOBlockReq.elem to pointer
>   virtio-blk: Drop bounce buffer from dataplane code
>   virtio-blk: Drop VirtIOBlockRequest.read
>   virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq
>   virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>   virtio-blk: Convert VirtIOBlockReq.out to structrue
>   virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>   virtio-blk: Fix and clean up the in_sg and out_sg check
>
>  hw/block/dataplane/virtio-blk.c | 167 +++++++++++++---------------------------
>  hw/block/virtio-blk.c           | 113 ++++++++++++++-------------
>  include/hw/virtio/virtio-blk.h  |  11 +++
>  3 files changed, 124 insertions(+), 167 deletions(-)
>

Nice diffstat, too. :)

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>