From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WspFV-0005wa-PM
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 04:11:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WspFM-0000eE-OS
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 04:11:41 -0400
Received: from mail-qg0-x22c.google.com ([2607:f8b0:400d:c04::22c]:53926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WspFM-0000e8-Ic
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 04:11:32 -0400
Received: by mail-qg0-f44.google.com with SMTP id i50so3708926qgf.3
	for <qemu-devel@nongnu.org>; Fri, 06 Jun 2014 01:11:32 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <539177AF.5090603@redhat.com>
Date: Fri, 06 Jun 2014 10:11:27 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1401273557-6578-1-git-send-email-cornelia.huck@de.ibm.com>	<1401273557-6578-2-git-send-email-cornelia.huck@de.ibm.com>
	<20140606094109.577477ea.cornelia.huck@de.ibm.com>
In-Reply-To: <20140606094109.577477ea.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: unset interfering
	variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>

Il 06/06/2014 09:41, Cornelia Huck ha scritto:
> On Wed, 28 May 2014 12:39:17 +0200
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
>> The check for big or little endianness relies on grep reporting
>> match/non-match on the generated binary. If the user specified
>> --binary-files=without-match in their GREP_OPTIONS, this will fail.
>>
>> Let's follow what autoconf does and unset GREP_OPTIONS and CLICOLOR_FORCE
>> at the beginning of the script.
>>
>> Reported-by: Eugene (jno) Dvurechenski <jno@linux.vnet.ibm.com>
>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  configure | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 0e516f9..525da56 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3,6 +3,11 @@
>>  # qemu configure script (c) 2003 Fabrice Bellard
>>  #
>>
>> +# Unset some variables known to interfere with behavior of common tools,
>> +# just as autoconf does.
>> +CLICOLOR_FORCE= GREP_OPTIONS=
>> +unset CLICOLOR_FORCE GREP_OPTIONS
>> +
>>  # Temporary directory used for files created while
>>  # configure runs. Since it is in the build directory
>>  # we can safely blow away any previous version of it
>
> Is there an obvious tree to merge configure changes through, or should
> I just throw it into my next s390 pull request?

Hi,

I picked up this patch and will push it to a "configure" branch on github.

Paolo