From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WstVY-00077B-CV for qemu-devel@nongnu.org; Fri, 06 Jun 2014 08:44:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WstVS-0003sU-O3 for qemu-devel@nongnu.org; Fri, 06 Jun 2014 08:44:32 -0400 Received: from fldsmtpe04.verizon.com ([140.108.26.143]:29773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WstVS-0003sI-I8 for qemu-devel@nongnu.org; Fri, 06 Jun 2014 08:44:26 -0400 From: Don Slutz Message-ID: <5391B7A7.2030909@terremark.com> Date: Fri, 06 Jun 2014 08:44:23 -0400 MIME-Version: 1.0 References: <1401715529-636-1-git-send-email-imammedo@redhat.com> <1401715529-636-34-git-send-email-imammedo@redhat.com> In-Reply-To: <1401715529-636-34-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 33/33] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com This also generates warnings during "make check": GTESTER check-qtest-i386 blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' main-loop: WARNING: I/O thread spun for 1000 iterations acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-6P9HHX.dsl, aml:/tmp/aml-ACAIHX], Expected [asl:/tmp/asl-2Y4GHX.dsl, aml:tests/acpi-test-data/pc/DSDT]. main-loop: WARNING: I/O thread spun for 1000 iterations acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-T24HHX.dsl, aml:/tmp/aml-SO5HHX], Expected [asl:/tmp/asl-BYAIHX.dsl, aml:tests/acpi-test-data/q35/DSDT]. -Don Slutz On 06/02/14 09:25, Igor Mammedov wrote: > also make handler edge based to avoid losing events, the same as > it has been done for PCI and CPU hotplug handlers. > > Signed-off-by: Igor Mammedov > Acked-by: Peter Crosthwaite > --- > v2: > * use memory hotplug crtl located under PCI0 > --- > hw/i386/acpi-dsdt.dsl | 5 ++++- > hw/i386/q35-acpi-dsdt.dsl | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt.dsl > index 8ae933b..3cc0ea0 100644 > --- a/hw/i386/acpi-dsdt.dsl > +++ b/hw/i386/acpi-dsdt.dsl > @@ -314,6 +314,7 @@ DefinitionBlock ( > /**************************************************************** > * General purpose events > ****************************************************************/ > + External(\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD, MethodObj) > > Scope(\_GPE) { > Name(_HID, "ACPI0006") > @@ -330,7 +331,9 @@ DefinitionBlock ( > // CPU hotplug event > \_SB.PRSC() > } > - Method(_L03) { > + Method(_E03) { > + // Memory hotplug event > + \_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD() > } > Method(_L04) { > } > diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl > index fddc3b2..8c3eae7 100644 > --- a/hw/i386/q35-acpi-dsdt.dsl > +++ b/hw/i386/q35-acpi-dsdt.dsl > @@ -410,6 +410,7 @@ DefinitionBlock ( > /**************************************************************** > * General purpose events > ****************************************************************/ > + External(\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD, MethodObj) > > Scope(\_GPE) { > Name(_HID, "ACPI0006") > @@ -422,7 +423,9 @@ DefinitionBlock ( > // CPU hotplug event > \_SB.PRSC() > } > - Method(_L03) { > + Method(_E03) { > + // Memory hotplug event > + \_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD() > } > Method(_L04) { > }