From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsu2B-0002RZ-Nh
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:18:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsu25-0007Pd-Kk
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:18:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsu25-0007Nv-CK
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:18:09 -0400
Message-ID: <5391BF8A.8000709@redhat.com>
Date: Fri, 06 Jun 2014 15:18:02 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402019610-2985-1-git-send-email-famz@redhat.com>
	<1402019610-2985-10-git-send-email-famz@redhat.com>
	<20140606131649.GE14322@stefanha-thinkpad>
In-Reply-To: <20140606131649.GE14322@stefanha-thinkpad>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 9/9] virtio-blk: Fix and clean up the
 in_sg and out_sg check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Il 06/06/2014 15:16, Stefan Hajnoczi ha scritto:
>> > -    req->in = (void *)req->elem->in_sg[req->elem->in_num - 1].iov_base;
>> > +    assert(in_iov[in_num - 1].iov_len >=
>> > +           sizeof(struct virtio_blk_inhdr));
> Why use assert() when the rest of the function uses error_report() +
> exit(1)?  Please keep the code consistent.

Sorry, that's my fault.  I suggested assert thinking that zero-length 
iovecs wouldn't be possible here.

Paolo