qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] KVM: Fix GSI number space limit
Date: Fri, 06 Jun 2014 18:31:14 +0200	[thread overview]
Message-ID: <5391ECD2.3060507@redhat.com> (raw)
In-Reply-To: <1402058765-48921-1-git-send-email-agraf@suse.de>

Il 06/06/2014 14:46, Alexander Graf ha scritto:
> KVM tells us the number of GSIs it can handle inside the kernel. That value is
> basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI mapping table,
> it checks for
>
>     r = -EINVAL;
>     if (routing.nr >= KVM_MAX_IRQ_ROUTES)
>         goto out;
>
> erroring out even when we're only using all of the GSIs. To make sure we never
> hit that limit, let's reduce the number of GSIs we get from KVM by one.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  kvm-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 4e19eff..56a251b 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -938,7 +938,7 @@ void kvm_init_irq_routing(KVMState *s)
>  {
>      int gsi_count, i;
>
> -    gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING);
> +    gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING) - 1;
>      if (gsi_count > 0) {
>          unsigned int gsi_bits, i;
>
>

Applied, thanks!

Paolo

  parent reply	other threads:[~2014-06-06 16:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 12:46 [Qemu-devel] [PATCH] KVM: Fix GSI number space limit Alexander Graf
2014-06-06 13:12 ` Cornelia Huck
2014-06-06 13:15   ` Alexander Graf
2014-06-06 13:23     ` Cornelia Huck
2014-06-06 13:28       ` Alexander Graf
2014-06-06 13:41         ` Cornelia Huck
2014-06-06 16:31 ` Paolo Bonzini [this message]
2014-06-07  0:31   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5391ECD2.3060507@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).