From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsx35-0002jH-5q
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:31:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsx2z-00022H-P9
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:31:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wsx2z-000228-Fs
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:31:17 -0400
Message-ID: <5391ECD2.3060507@redhat.com>
Date: Fri, 06 Jun 2014 18:31:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402058765-48921-1-git-send-email-agraf@suse.de>
In-Reply-To: <1402058765-48921-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] KVM: Fix GSI number space limit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org

Il 06/06/2014 14:46, Alexander Graf ha scritto:
> KVM tells us the number of GSIs it can handle inside the kernel. That value is
> basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI mapping table,
> it checks for
>
>     r = -EINVAL;
>     if (routing.nr >= KVM_MAX_IRQ_ROUTES)
>         goto out;
>
> erroring out even when we're only using all of the GSIs. To make sure we never
> hit that limit, let's reduce the number of GSIs we get from KVM by one.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  kvm-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 4e19eff..56a251b 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -938,7 +938,7 @@ void kvm_init_irq_routing(KVMState *s)
>  {
>      int gsi_count, i;
>
> -    gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING);
> +    gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING) - 1;
>      if (gsi_count > 0) {
>          unsigned int gsi_bits, i;
>
>

Applied, thanks!

Paolo