From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] vnc: Drop superfluous conditionals around g_strdup()
Date: Fri, 06 Jun 2014 18:38:51 +0200 [thread overview]
Message-ID: <5391EE9B.60707@redhat.com> (raw)
In-Reply-To: <1402072618-7103-3-git-send-email-armbru@redhat.com>
Il 06/06/2014 18:36, Markus Armbruster ha scritto:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/vnc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index d771a2c..0853ded 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3010,9 +3010,7 @@ int vnc_display_password(DisplayState *ds, const char *password)
>
> g_free(vs->password);
> vs->password = NULL;
> - if (password) {
> - vs->password = g_strdup(password);
> - }
> + vs->password = g_strdup(password);
You have a dead store now. :)
Paolo
> return 0;
> }
>
next prev parent reply other threads:[~2014-06-06 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 16:36 [Qemu-devel] [PATCH 0/2] vnc: Drop some superfluous conditionals Markus Armbruster
2014-06-06 16:36 ` [Qemu-devel] [PATCH 1/2] vnc: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 16:45 ` Eric Blake
2014-06-06 16:36 ` [Qemu-devel] [PATCH 2/2] vnc: Drop superfluous conditionals around g_strdup() Markus Armbruster
2014-06-06 16:38 ` Paolo Bonzini [this message]
2014-06-06 16:50 ` Markus Armbruster
2014-06-06 16:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391EE9B.60707@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).