From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsxXF-0001FA-LK for qemu-devel@nongnu.org; Fri, 06 Jun 2014 13:02:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsxX7-00069i-UY for qemu-devel@nongnu.org; Fri, 06 Jun 2014 13:02:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsxX7-00068A-KR for qemu-devel@nongnu.org; Fri, 06 Jun 2014 13:02:25 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s56H2Ou5016193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 6 Jun 2014 13:02:24 -0400 Message-ID: <5391F41F.4090407@redhat.com> Date: Fri, 06 Jun 2014 11:02:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402073264-9606-1-git-send-email-armbru@redhat.com> <1402073264-9606-2-git-send-email-armbru@redhat.com> In-Reply-To: <1402073264-9606-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eA56x82wIsDUXu3o9MlpgW909xOanELx6" Subject: Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eA56x82wIsDUXu3o9MlpgW909xOanELx6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2014 10:47 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > ui/vnc-tls.c | 6 ++---- > ui/vnc.c | 12 ++++-------- > 2 files changed, 6 insertions(+), 12 deletions(-) >=20 > diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c > index 50275de..6392326 100644 > --- a/ui/vnc-tls.c > +++ b/ui/vnc-tls.c > @@ -443,10 +443,8 @@ static int vnc_set_x509_credential(VncDisplay *vd,= > { > struct stat sb; > =20 > - if (*cred) { > - g_free(*cred); > - *cred =3D NULL; > - } > + g_free(*cred); > + *cred =3D NULL; > =20 > *cred =3D g_malloc(strlen(certdir) + strlen(filename) + 2); Still a dead store --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eA56x82wIsDUXu3o9MlpgW909xOanELx6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTkfQfAAoJEKeha0olJ0NqZPIH/Amc7wFJigmW6WzJ6ryDikTI Y9RlCxbeZGnX6eFSN1KwkAEYpO+lOvpg1qlHIwE1fIFFPyyLt6H2cht3KfiabF50 +s2nXBM2dCVeXQExPnb2exrjjRx2Pon52BpinBJu/frrW2TNjx9zThnADTJvG8IO bFZHBm/nnDAN9sCRYWIshg6eNxSDTVsGS8fcUSYugPpUzOtZjegzOnkehuq8tolI zm5BGsUmMQ6wGoNjD5mTZqpSR5XVKQWiklUsMTFI1zq6tl+vuBCX3A2vPXZZ6vJs jzHf1zgdgKfJIHM+/LqewXfSDLSnF3Hls/Iie4fyLjr8XLKFgRg/Wj0AB1hkmdo= =yy6F -----END PGP SIGNATURE----- --eA56x82wIsDUXu3o9MlpgW909xOanELx6--