* [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free()
@ 2014-06-06 16:32 Markus Armbruster
2014-06-06 16:39 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Markus Armbruster @ 2014-06-06 16:32 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, alevy
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
libcacard/cac.c | 14 ++++----------
libcacard/card_7816.c | 12 +++---------
libcacard/vcard.c | 10 +++-------
libcacard/vcard_emul_nss.c | 4 +---
libcacard/vreader.c | 4 +---
5 files changed, 12 insertions(+), 32 deletions(-)
diff --git a/libcacard/cac.c b/libcacard/cac.c
index 0a0163d..ae8c378 100644
--- a/libcacard/cac.c
+++ b/libcacard/cac.c
@@ -100,10 +100,8 @@ cac_applet_pki_reset(VCard *card, int channel)
pki_applet = &(applet_private->u.pki_data);
pki_applet->cert_buffer = NULL;
- if (pki_applet->sign_buffer) {
- g_free(pki_applet->sign_buffer);
- pki_applet->sign_buffer = NULL;
- }
+ g_free(pki_applet->sign_buffer);
+ pki_applet->sign_buffer = NULL;
pki_applet->cert_buffer_len = 0;
pki_applet->sign_buffer_len = 0;
return VCARD_DONE;
@@ -285,12 +283,8 @@ cac_delete_pki_applet_private(VCardAppletPrivate *applet_private)
return;
}
pki_applet_data = &(applet_private->u.pki_data);
- if (pki_applet_data->cert != NULL) {
- g_free(pki_applet_data->cert);
- }
- if (pki_applet_data->sign_buffer != NULL) {
- g_free(pki_applet_data->sign_buffer);
- }
+ g_free(pki_applet_data->cert);
+ g_free(pki_applet_data->sign_buffer);
if (pki_applet_data->key != NULL) {
vcard_emul_delete_key(pki_applet_data->key);
}
diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
index a54f880..814fa16 100644
--- a/libcacard/card_7816.c
+++ b/libcacard/card_7816.c
@@ -172,16 +172,12 @@ vcard_response_delete(VCardResponse *response)
switch (response->b_type) {
case VCARD_MALLOC:
/* everything was malloc'ed */
- if (response->b_data) {
- g_free(response->b_data);
- }
+ g_free(response->b_data);
g_free(response);
break;
case VCARD_MALLOC_DATA:
/* only the data buffer was malloc'ed */
- if (response->b_data) {
- g_free(response->b_data);
- }
+ g_free(response->b_data);
break;
case VCARD_MALLOC_STRUCT:
/* only the structure was malloc'ed */
@@ -358,9 +354,7 @@ vcard_apdu_delete(VCardAPDU *apdu)
if (apdu == NULL) {
return;
}
- if (apdu->a_data) {
- g_free(apdu->a_data);
- }
+ g_free(apdu->a_data);
g_free(apdu);
}
diff --git a/libcacard/vcard.c b/libcacard/vcard.c
index 6aaf085..bf342aa 100644
--- a/libcacard/vcard.c
+++ b/libcacard/vcard.c
@@ -51,9 +51,7 @@ vcard_buffer_response_delete(VCardBufferResponse *buffer_response)
if (buffer_response == NULL) {
return;
}
- if (buffer_response->buffer) {
- g_free(buffer_response->buffer);
- }
+ g_free(buffer_response->buffer);
g_free(buffer_response);
}
@@ -121,10 +119,8 @@ vcard_delete_applet(VCardApplet *applet)
applet->applet_private_free(applet->applet_private);
applet->applet_private = NULL;
}
- if (applet->aid) {
- g_free(applet->aid);
- applet->aid = NULL;
- }
+ g_free(applet->aid);
+ applet->aid = NULL;
g_free(applet);
}
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index cefc383..f1bba57 100644
--- a/libcacard/vcard_emul_nss.c
+++ b/libcacard/vcard_emul_nss.c
@@ -471,9 +471,7 @@ vreader_emul_delete(VReaderEmul *vreader_emul)
if (vreader_emul->slot) {
PK11_FreeSlot(vreader_emul->slot);
}
- if (vreader_emul->type_params) {
- g_free(vreader_emul->type_params);
- }
+ g_free(vreader_emul->type_params);
g_free(vreader_emul);
}
diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index d2a9b7d..ffa05b6 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreader.c
@@ -155,9 +155,7 @@ vreader_free(VReader *reader)
if (reader->card) {
vcard_free(reader->card);
}
- if (reader->name) {
- g_free(reader->name);
- }
+ g_free(reader->name);
if (reader->reader_private_free) {
reader->reader_private_free(reader->reader_private);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free()
2014-06-06 16:32 [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free() Markus Armbruster
@ 2014-06-06 16:39 ` Paolo Bonzini
2014-06-06 16:59 ` Markus Armbruster
2014-06-06 19:30 ` [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free() Markus Armbruster
2014-06-08 13:45 ` [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: Drop superfluous conditionals around g_free() Michael Tokarev
2 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2014-06-06 16:39 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: qemu-trivial, alevy
Il 06/06/2014 18:32, Markus Armbruster ha scritto:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> libcacard/cac.c | 14 ++++----------
> libcacard/card_7816.c | 12 +++---------
> libcacard/vcard.c | 10 +++-------
> libcacard/vcard_emul_nss.c | 4 +---
> libcacard/vreader.c | 4 +---
> 5 files changed, 12 insertions(+), 32 deletions(-)
>
> diff --git a/libcacard/cac.c b/libcacard/cac.c
> index 0a0163d..ae8c378 100644
> --- a/libcacard/cac.c
> +++ b/libcacard/cac.c
> @@ -100,10 +100,8 @@ cac_applet_pki_reset(VCard *card, int channel)
> pki_applet = &(applet_private->u.pki_data);
>
> pki_applet->cert_buffer = NULL;
> - if (pki_applet->sign_buffer) {
> - g_free(pki_applet->sign_buffer);
> - pki_applet->sign_buffer = NULL;
> - }
> + g_free(pki_applet->sign_buffer);
> + pki_applet->sign_buffer = NULL;
> pki_applet->cert_buffer_len = 0;
> pki_applet->sign_buffer_len = 0;
> return VCARD_DONE;
> @@ -285,12 +283,8 @@ cac_delete_pki_applet_private(VCardAppletPrivate *applet_private)
> return;
> }
> pki_applet_data = &(applet_private->u.pki_data);
> - if (pki_applet_data->cert != NULL) {
> - g_free(pki_applet_data->cert);
> - }
> - if (pki_applet_data->sign_buffer != NULL) {
> - g_free(pki_applet_data->sign_buffer);
> - }
> + g_free(pki_applet_data->cert);
> + g_free(pki_applet_data->sign_buffer);
> if (pki_applet_data->key != NULL) {
> vcard_emul_delete_key(pki_applet_data->key);
> }
> diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
> index a54f880..814fa16 100644
> --- a/libcacard/card_7816.c
> +++ b/libcacard/card_7816.c
> @@ -172,16 +172,12 @@ vcard_response_delete(VCardResponse *response)
> switch (response->b_type) {
> case VCARD_MALLOC:
> /* everything was malloc'ed */
> - if (response->b_data) {
> - g_free(response->b_data);
> - }
> + g_free(response->b_data);
> g_free(response);
> break;
> case VCARD_MALLOC_DATA:
> /* only the data buffer was malloc'ed */
> - if (response->b_data) {
> - g_free(response->b_data);
> - }
> + g_free(response->b_data);
> break;
> case VCARD_MALLOC_STRUCT:
> /* only the structure was malloc'ed */
> @@ -358,9 +354,7 @@ vcard_apdu_delete(VCardAPDU *apdu)
> if (apdu == NULL) {
> return;
> }
> - if (apdu->a_data) {
> - g_free(apdu->a_data);
> - }
> + g_free(apdu->a_data);
> g_free(apdu);
> }
>
> diff --git a/libcacard/vcard.c b/libcacard/vcard.c
> index 6aaf085..bf342aa 100644
> --- a/libcacard/vcard.c
> +++ b/libcacard/vcard.c
> @@ -51,9 +51,7 @@ vcard_buffer_response_delete(VCardBufferResponse *buffer_response)
> if (buffer_response == NULL) {
> return;
> }
> - if (buffer_response->buffer) {
> - g_free(buffer_response->buffer);
> - }
> + g_free(buffer_response->buffer);
> g_free(buffer_response);
> }
>
> @@ -121,10 +119,8 @@ vcard_delete_applet(VCardApplet *applet)
> applet->applet_private_free(applet->applet_private);
> applet->applet_private = NULL;
Dead store here...
> }
> - if (applet->aid) {
> - g_free(applet->aid);
> - applet->aid = NULL;
> - }
> + g_free(applet->aid);
> + applet->aid = NULL;
... and here (didn't check if there are more out of context).
As usual, no good deed goes unpunished!
Paolo
> g_free(applet);
> }
>
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index cefc383..f1bba57 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -471,9 +471,7 @@ vreader_emul_delete(VReaderEmul *vreader_emul)
> if (vreader_emul->slot) {
> PK11_FreeSlot(vreader_emul->slot);
> }
> - if (vreader_emul->type_params) {
> - g_free(vreader_emul->type_params);
> - }
> + g_free(vreader_emul->type_params);
> g_free(vreader_emul);
> }
>
> diff --git a/libcacard/vreader.c b/libcacard/vreader.c
> index d2a9b7d..ffa05b6 100644
> --- a/libcacard/vreader.c
> +++ b/libcacard/vreader.c
> @@ -155,9 +155,7 @@ vreader_free(VReader *reader)
> if (reader->card) {
> vcard_free(reader->card);
> }
> - if (reader->name) {
> - g_free(reader->name);
> - }
> + g_free(reader->name);
> if (reader->reader_private_free) {
> reader->reader_private_free(reader->reader_private);
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free()
2014-06-06 16:39 ` Paolo Bonzini
@ 2014-06-06 16:59 ` Markus Armbruster
2014-06-06 17:20 ` Paolo Bonzini
0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2014-06-06 16:59 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, alevy, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 06/06/2014 18:32, Markus Armbruster ha scritto:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> libcacard/cac.c | 14 ++++----------
>> libcacard/card_7816.c | 12 +++---------
>> libcacard/vcard.c | 10 +++-------
>> libcacard/vcard_emul_nss.c | 4 +---
>> libcacard/vreader.c | 4 +---
>> 5 files changed, 12 insertions(+), 32 deletions(-)
>>
>> diff --git a/libcacard/cac.c b/libcacard/cac.c
>> index 0a0163d..ae8c378 100644
>> --- a/libcacard/cac.c
>> +++ b/libcacard/cac.c
>> @@ -100,10 +100,8 @@ cac_applet_pki_reset(VCard *card, int channel)
>> pki_applet = &(applet_private->u.pki_data);
>>
>> pki_applet->cert_buffer = NULL;
>> - if (pki_applet->sign_buffer) {
>> - g_free(pki_applet->sign_buffer);
>> - pki_applet->sign_buffer = NULL;
>> - }
>> + g_free(pki_applet->sign_buffer);
>> + pki_applet->sign_buffer = NULL;
>> pki_applet->cert_buffer_len = 0;
>> pki_applet->sign_buffer_len = 0;
>> return VCARD_DONE;
>> @@ -285,12 +283,8 @@ cac_delete_pki_applet_private(VCardAppletPrivate *applet_private)
>> return;
>> }
>> pki_applet_data = &(applet_private->u.pki_data);
>> - if (pki_applet_data->cert != NULL) {
>> - g_free(pki_applet_data->cert);
>> - }
>> - if (pki_applet_data->sign_buffer != NULL) {
>> - g_free(pki_applet_data->sign_buffer);
>> - }
>> + g_free(pki_applet_data->cert);
>> + g_free(pki_applet_data->sign_buffer);
>> if (pki_applet_data->key != NULL) {
>> vcard_emul_delete_key(pki_applet_data->key);
>> }
>> diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
>> index a54f880..814fa16 100644
>> --- a/libcacard/card_7816.c
>> +++ b/libcacard/card_7816.c
>> @@ -172,16 +172,12 @@ vcard_response_delete(VCardResponse *response)
>> switch (response->b_type) {
>> case VCARD_MALLOC:
>> /* everything was malloc'ed */
>> - if (response->b_data) {
>> - g_free(response->b_data);
>> - }
>> + g_free(response->b_data);
>> g_free(response);
>> break;
>> case VCARD_MALLOC_DATA:
>> /* only the data buffer was malloc'ed */
>> - if (response->b_data) {
>> - g_free(response->b_data);
>> - }
>> + g_free(response->b_data);
>> break;
>> case VCARD_MALLOC_STRUCT:
>> /* only the structure was malloc'ed */
>> @@ -358,9 +354,7 @@ vcard_apdu_delete(VCardAPDU *apdu)
>> if (apdu == NULL) {
>> return;
>> }
>> - if (apdu->a_data) {
>> - g_free(apdu->a_data);
>> - }
>> + g_free(apdu->a_data);
>> g_free(apdu);
>> }
>>
>> diff --git a/libcacard/vcard.c b/libcacard/vcard.c
>> index 6aaf085..bf342aa 100644
>> --- a/libcacard/vcard.c
>> +++ b/libcacard/vcard.c
>> @@ -51,9 +51,7 @@ vcard_buffer_response_delete(VCardBufferResponse *buffer_response)
>> if (buffer_response == NULL) {
>> return;
>> }
>> - if (buffer_response->buffer) {
>> - g_free(buffer_response->buffer);
>> - }
>> + g_free(buffer_response->buffer);
>> g_free(buffer_response);
>> }
>>
>> @@ -121,10 +119,8 @@ vcard_delete_applet(VCardApplet *applet)
>> applet->applet_private_free(applet->applet_private);
>> applet->applet_private = NULL;
>
> Dead store here...
>
>> }
>> - if (applet->aid) {
>> - g_free(applet->aid);
>> - applet->aid = NULL;
>> - }
>> + g_free(applet->aid);
>> + applet->aid = NULL;
>
> ... and here (didn't check if there are more out of context).
>
> As usual, no good deed goes unpunished!
Preexisting. I can try to clean them up in a follow-up patch. Okay?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free()
2014-06-06 16:59 ` Markus Armbruster
@ 2014-06-06 17:20 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2014-06-06 17:20 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-trivial, alevy, qemu-devel
Il 06/06/2014 18:59, Markus Armbruster ha scritto:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 06/06/2014 18:32, Markus Armbruster ha scritto:
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>> libcacard/cac.c | 14 ++++----------
>>> libcacard/card_7816.c | 12 +++---------
>>> libcacard/vcard.c | 10 +++-------
>>> libcacard/vcard_emul_nss.c | 4 +---
>>> libcacard/vreader.c | 4 +---
>>> 5 files changed, 12 insertions(+), 32 deletions(-)
>>>
>>> diff --git a/libcacard/cac.c b/libcacard/cac.c
>>> index 0a0163d..ae8c378 100644
>>> --- a/libcacard/cac.c
>>> +++ b/libcacard/cac.c
>>> @@ -100,10 +100,8 @@ cac_applet_pki_reset(VCard *card, int channel)
>>> pki_applet = &(applet_private->u.pki_data);
>>>
>>> pki_applet->cert_buffer = NULL;
>>> - if (pki_applet->sign_buffer) {
>>> - g_free(pki_applet->sign_buffer);
>>> - pki_applet->sign_buffer = NULL;
>>> - }
>>> + g_free(pki_applet->sign_buffer);
>>> + pki_applet->sign_buffer = NULL;
>>> pki_applet->cert_buffer_len = 0;
>>> pki_applet->sign_buffer_len = 0;
>>> return VCARD_DONE;
>>> @@ -285,12 +283,8 @@ cac_delete_pki_applet_private(VCardAppletPrivate *applet_private)
>>> return;
>>> }
>>> pki_applet_data = &(applet_private->u.pki_data);
>>> - if (pki_applet_data->cert != NULL) {
>>> - g_free(pki_applet_data->cert);
>>> - }
>>> - if (pki_applet_data->sign_buffer != NULL) {
>>> - g_free(pki_applet_data->sign_buffer);
>>> - }
>>> + g_free(pki_applet_data->cert);
>>> + g_free(pki_applet_data->sign_buffer);
>>> if (pki_applet_data->key != NULL) {
>>> vcard_emul_delete_key(pki_applet_data->key);
>>> }
>>> diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
>>> index a54f880..814fa16 100644
>>> --- a/libcacard/card_7816.c
>>> +++ b/libcacard/card_7816.c
>>> @@ -172,16 +172,12 @@ vcard_response_delete(VCardResponse *response)
>>> switch (response->b_type) {
>>> case VCARD_MALLOC:
>>> /* everything was malloc'ed */
>>> - if (response->b_data) {
>>> - g_free(response->b_data);
>>> - }
>>> + g_free(response->b_data);
>>> g_free(response);
>>> break;
>>> case VCARD_MALLOC_DATA:
>>> /* only the data buffer was malloc'ed */
>>> - if (response->b_data) {
>>> - g_free(response->b_data);
>>> - }
>>> + g_free(response->b_data);
>>> break;
>>> case VCARD_MALLOC_STRUCT:
>>> /* only the structure was malloc'ed */
>>> @@ -358,9 +354,7 @@ vcard_apdu_delete(VCardAPDU *apdu)
>>> if (apdu == NULL) {
>>> return;
>>> }
>>> - if (apdu->a_data) {
>>> - g_free(apdu->a_data);
>>> - }
>>> + g_free(apdu->a_data);
>>> g_free(apdu);
>>> }
>>>
>>> diff --git a/libcacard/vcard.c b/libcacard/vcard.c
>>> index 6aaf085..bf342aa 100644
>>> --- a/libcacard/vcard.c
>>> +++ b/libcacard/vcard.c
>>> @@ -51,9 +51,7 @@ vcard_buffer_response_delete(VCardBufferResponse *buffer_response)
>>> if (buffer_response == NULL) {
>>> return;
>>> }
>>> - if (buffer_response->buffer) {
>>> - g_free(buffer_response->buffer);
>>> - }
>>> + g_free(buffer_response->buffer);
>>> g_free(buffer_response);
>>> }
>>>
>>> @@ -121,10 +119,8 @@ vcard_delete_applet(VCardApplet *applet)
>>> applet->applet_private_free(applet->applet_private);
>>> applet->applet_private = NULL;
>>
>> Dead store here...
>>
>>> }
>>> - if (applet->aid) {
>>> - g_free(applet->aid);
>>> - applet->aid = NULL;
>>> - }
>>> + g_free(applet->aid);
>>> + applet->aid = NULL;
>>
>> ... and here (didn't check if there are more out of context).
>>
>> As usual, no good deed goes unpunished!
>
> Preexisting. I can try to clean them up in a follow-up patch. Okay?
Sure.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free()
2014-06-06 16:32 [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 16:39 ` Paolo Bonzini
@ 2014-06-06 19:30 ` Markus Armbruster
2014-06-06 21:33 ` Eric Blake
2014-06-08 13:45 ` [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: Drop superfluous conditionals around g_free() Michael Tokarev
2 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2014-06-06 19:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, alevy
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
libcacard/vcard.c | 4 ----
libcacard/vreader.c | 2 --
2 files changed, 6 deletions(-)
diff --git a/libcacard/vcard.c b/libcacard/vcard.c
index bf342aa..87ad516 100644
--- a/libcacard/vcard.c
+++ b/libcacard/vcard.c
@@ -117,10 +117,8 @@ vcard_delete_applet(VCardApplet *applet)
}
if (applet->applet_private_free) {
applet->applet_private_free(applet->applet_private);
- applet->applet_private = NULL;
}
g_free(applet->aid);
- applet->aid = NULL;
g_free(applet);
}
@@ -174,8 +172,6 @@ vcard_free(VCard *vcard)
}
if (vcard->vcard_private_free) {
(*vcard->vcard_private_free)(vcard->vcard_private);
- vcard->vcard_private_free = 0;
- vcard->vcard_private = 0;
}
for (current_applet = vcard->applet_list; current_applet;
current_applet = next_applet) {
diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index ffa05b6..9f42f0f 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreader.c
@@ -343,8 +343,6 @@ vreader_list_delete(VReaderList *list)
next_entry = vreader_list_get_next(current_entry);
vreader_list_entry_delete(current_entry);
}
- list->head = NULL;
- list->tail = NULL;
g_free(list);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free()
2014-06-06 19:30 ` [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free() Markus Armbruster
@ 2014-06-06 21:33 ` Eric Blake
0 siblings, 0 replies; 7+ messages in thread
From: Eric Blake @ 2014-06-06 21:33 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: qemu-trivial, pbonzini, alevy
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
On 06/06/2014 01:30 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> libcacard/vcard.c | 4 ----
> libcacard/vreader.c | 2 --
> 2 files changed, 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: Drop superfluous conditionals around g_free()
2014-06-06 16:32 [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 16:39 ` Paolo Bonzini
2014-06-06 19:30 ` [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free() Markus Armbruster
@ 2014-06-08 13:45 ` Michael Tokarev
2 siblings, 0 replies; 7+ messages in thread
From: Michael Tokarev @ 2014-06-08 13:45 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: qemu-trivial, alevy
Applied both to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-08 13:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-06 16:32 [Qemu-devel] [PATCH] libcacard: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 16:39 ` Paolo Bonzini
2014-06-06 16:59 ` Markus Armbruster
2014-06-06 17:20 ` Paolo Bonzini
2014-06-06 19:30 ` [Qemu-devel] [PATCH 2/1] libcacard: Clean up dead stores before g_free() Markus Armbruster
2014-06-06 21:33 ` Eric Blake
2014-06-08 13:45 ` [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: Drop superfluous conditionals around g_free() Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).