From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WtirB-0004Vi-0u
	for qemu-devel@nongnu.org; Sun, 08 Jun 2014 15:34:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Wtir1-0005f7-W0
	for qemu-devel@nongnu.org; Sun, 08 Jun 2014 15:34:16 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5394BAA9.30609@twiddle.net>
Date: Sun, 08 Jun 2014 12:34:01 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1402160924-14152-1-git-send-email-peter.maydell@linaro.org>
	<539452F2.8070509@msgid.tls.msk.ru>
	<CAFEAcA-ngVhdG5EemWziTcUbgKtwb+yDsFMTCKK0nk=wfKU_2w@mail.gmail.com>
In-Reply-To: <CAFEAcA-ngVhdG5EemWziTcUbgKtwb+yDsFMTCKK0nk=wfKU_2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and
 tcg_patch* with attribute 'unused'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 06/08/2014 12:04 PM, Peter Maydell wrote:
> The other approach we could take would be to move these
> definitions from this .c file into a .h file (tcg-backend-helpers.h ?).
> Then clang won't complain (it seems to only warn about unused
> static-inline-functions in .c files, not in .h files).
> 
> Richard: do you have a preference?

I don't like the idea of moving these to a public header, and I don't think
it's worthwhile creating a new private header.  I'm ok with the unused attribute.


r~