From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WtzA8-0004jh-1k
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 08:59:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WtzA1-0003wR-Tc
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 08:58:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WtzA1-0003wM-L0
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 08:58:49 -0400
Message-ID: <5395AF7F.7000403@redhat.com>
Date: Mon, 09 Jun 2014 14:58:39 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1402299637.git.hutao@cn.fujitsu.com>	<66e17e32ccb10ca0ae262103fcf170b84511c3f8.1402299637.git.hutao@cn.fujitsu.com>
	<20140609143622.44fa7006@thinkpad>
In-Reply-To: <20140609143622.44fa7006@thinkpad>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Hu Tao <hutao@cn.fujitsu.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>

Il 09/06/2014 14:36, Igor Mammedov ha scritto:
>> > +{ 'type': 'Memdev',
>> > +  'data': {
>> > +    'size':       'size',
>> > +    'merge':      'bool',
>> > +    'dump':       'bool',
>> > +    'prealloc':   'bool',
>> > +    'host-nodes': ['uint16'],
>> > +    'policy':     'HostMemPolicy' }}
>> > +
>> > +##
>> > +# @query-memdev:
>> > +#
>> > +# Returns information for all memory devices.
>> > +#
>> > +# Returns: a list of @Memdev.
>> > +#
>> > +# Since: 2.1
>> > +##
>> > +{ 'command': 'query-memdev', 'returns': ['Memdev'] }
> Could we make it union, that returns MemdevRam + MemdevFile
>
> MemdevFile will have additional file-only specific properties.
>

Which are the file-only properties (in the current definition of Memdev)?

Paolo