From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu2pO-0000SF-7v for qemu-devel@nongnu.org; Mon, 09 Jun 2014 12:53:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wu2pH-0005dq-HQ for qemu-devel@nongnu.org; Mon, 09 Jun 2014 12:53:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu2pH-0005da-7n for qemu-devel@nongnu.org; Mon, 09 Jun 2014 12:53:39 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s59GrbWt001595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 9 Jun 2014 12:53:37 -0400 Message-ID: <5395E68F.5090508@redhat.com> Date: Mon, 09 Jun 2014 10:53:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402167080-20316-1-git-send-email-mreitz@redhat.com> <1402167080-20316-8-git-send-email-mreitz@redhat.com> In-Reply-To: <1402167080-20316-8-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="htFL8hNKDvOPtk7VVK3xkom4NUlaaun0Q" Subject: Re: [Qemu-devel] [PATCH v8 07/14] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --htFL8hNKDvOPtk7VVK3xkom4NUlaaun0Q Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/07/2014 12:51 PM, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically requir= e > just everything being linked into qemu-img), imitate QMP's > implementation of block-commit by using commit_active_start() and then > waiting for the block job to finish. >=20 > Signed-off-by: Max Reitz > --- > block/Makefile.objs | 2 +- > qemu-img.c | 83 +++++++++++++++++++++++++++++++++++++++++----= -------- > 2 files changed, 65 insertions(+), 20 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --htFL8hNKDvOPtk7VVK3xkom4NUlaaun0Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTleaPAAoJEKeha0olJ0NqGpoH/ias89RTZdBmHhRVQ5LXtKRX NmK0fjbOvMkgs7YcMdx+qqKihtrYoqXJWJm21zABpJd5OBnQOGX7luxIKyujVjYY mFKkcN22Zab1sFdThnRuw5dq1g6+EIwQQTipP7I4Tc/+2MzrUt7Mb306KcOJVlZh /Ujmj77+tm71RngSMJhDXn3Y5ACwf9/BYvpcozJFKStFa4Jxo8T9GIwZtv2a7+w3 dYv6Yrfwyd7/stkYWcHmIvAxxRXbW1vNtDm40W5uqMChUFZ2MsbAmZ9EvyuP4jQY 2zbcv/uwSejrkHbVs1XBTv5PdVyo9wzv+GsPguk/Zyu5Gn49fWoR1SkXlqVdq54= =jPbe -----END PGP SIGNATURE----- --htFL8hNKDvOPtk7VVK3xkom4NUlaaun0Q--